Add a builtin audio decoder to support caching audio files via the C_Resources API#150
Merged
rdw-software merged 4 commits intomainfrom Nov 17, 2021
Merged
Add a builtin audio decoder to support caching audio files via the C_Resources API#150rdw-software merged 4 commits intomainfrom
rdw-software merged 4 commits intomainfrom
Conversation
While it's a breaking change, it is needed to easily support multiple audio formats using the C_Resources cache.
While this doesn't do anything of significance, it allows the WebAudio API to load audio files from disk using the C_Decoding API, which means they'll be provided as cached resources. The alternative is to simply use BJS XHR-based loading, but that incurs a lot of overhead since it will load the file from disk every time. There's still overhead for copying buffers and decoding the ArrayBuffer to an AudioBuffer internally, but that'll require a more elaborate solution to eliminate.
rdw-software
force-pushed
the
54-builtin-audio-decoder
branch
from
1652365 to
e10ba6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for #130, but should likely be split off (if only to make that PR easier to review).