Skip to content

guard shrink-factor division against floating-point near-zero #57175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cipolleschi wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

guard shrink-factor division against floating-point near-zero #57175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-native/ReactCommon/yoga/yoga/algorithm/CalculateLayout.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,8 +929,15 @@ static float distributeFreeSpaceSecondPass(
if (flexShrinkScaledFactor != 0) {
float childSize = YGUndefined;

// Use a relative epsilon guard instead of exact equality: after the
// first pass removes all constrained items,
// totalFlexShrinkScaledFactors may be near-zero rather than exactly 0
// due to floating-point cancellation. Dividing by a near-zero value
// produces a gigantic childSize that overwhelms the min/max clamp.
const float shrinkFactorMagnitude =
std::abs(flexLine.layout.totalFlexShrinkScaledFactors);
if (yoga::isDefined(flexLine.layout.totalFlexShrinkScaledFactors) &&
flexLine.layout.totalFlexShrinkScaledFactors == 0) {
shrinkFactorMagnitude < 1e-6f) {
childSize = childFlexBasis + flexShrinkScaledFactor;
} else {
childSize = childFlexBasis +
Expand Down
Loading