Support external workspace root and translation context#156
Merged
Conversation
* Allow to define `WorkspaceRoot` and `TranslationProvider` as parent to the `Workspace` component so they can be shared between multiple workspaces or used outside the workspace itself. * Deprecate `translations`, `useDefaultTranslation` and `selectLabelLanguage` props on `Workspace` component in favor of wrapping the workspace in `TranslationProvider` with `DefaultTranslation`. * Remove deprecated `Translation.formatIri()` method (use `DataLocaleProvider.formatIri()` instead).
AlexeyMz
force-pushed
the
outer-root-and-i18n
branch
from
d5d4840 to
95b2c19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkspaceRootandTranslationProvideras parent to theWorkspacecomponent so they can be shared between multiple workspaces or used outside the workspace itself.translations,useDefaultTranslationandselectLabelLanguageprops onWorkspacecomponent in favor of wrapping the workspace inTranslationProviderwithDefaultTranslation.Translation.formatIri()method (useDataLocaleProvider.formatIri()instead).