Allow to customize link template separately for each link instead of only based on its link type IRI#84
Merged
Conversation
…only based on its link type IRI:
* `linkTemplateResolver` prop in `Canvas` now receives a second `Link` argument to be able to return
a different link template for a specific link;
* Link templates and markers are now longer cached based on link type IRI, so it is recommended to
always return a stable template and marker object for the same link to avoid unnecessary marker updates;
* `LinkTemplate.markerTarget` will no longer fallback to default marker target if only some styles
are overriden, and instead require an explicit `{...Reactodia.DefaultLinkTemplate.markerTarget}` in that case;
AlexeyMz
force-pushed
the
resolve-link-template-by-link-itself
branch
from
e255ac4 to
6882618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linkTemplateResolverprop inCanvasnow receives a secondLinkargument to be able to return a different link template for a specific link;LinkTemplate.markerTargetwill no longer fallback to default marker target if only some styles are overriden, and instead require an explicit{...Reactodia.DefaultLinkTemplate.markerTarget}in that case;