Fix connection leak in ReportController causing CLOSE_WAIT connections #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed CloseableHttpResponse not being closed in the report() method. This was causing connections to remain in CLOSE_WAIT state when reporting PDF generation metrics to the report service. Changed to use try-with-resources pattern to ensure both CloseableHttpClient and CloseableHttpResponse are properly closed after use. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
|
Hi Adam, Claude suggestions looks ok to me, I think you can try it. Ideally first in dev to make sure it doesn't break anything before moving it to production to see if it really fixes the issue though |
Author
|
@EliotRagueneau thanks. I will look into doing this with @jweiser asap. Thanks for taking a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed CloseableHttpResponse not being closed in the report() method. This was causing connections to remain in CLOSE_WAIT state when reporting PDF generation metrics to the report service.
Changed to use try-with-resources pattern to ensure both CloseableHttpClient and CloseableHttpResponse are properly closed after use.
🤖 Generated with Claude Code
@EliotRagueneau, @jweiser and I worked on this repo in addition to the content service where we have another PR. We are trying to fix the CLOSE_WAIT connections. We realize that you are on vacation. If you are not able to work on this that is fine. What we did so far was change the code and compiled it. If we need to we would be willing to roll it out into production. We just need to know if what is on production is from the latest commit on the master branch. And if there is anything else we should know about deploying it? we will make sure to test to see that it is running correctly and monitor it when it is deployed.