Pin reactor-runtime in the brightness and echo example requirements - #155
Merged
Conversation
reactor build --no-dockerfile no longer derives the runtime's pip install from reactor.yaml's build.runtime_version alone - the pin belongs in requirements.txt, matching what reactor init scaffolds. Without it the generated image never installs reactor-runtime and reactor run fails with ModuleNotFoundError. Both examples also pick up the apiVersion/kind header reactor.yaml now expects. Signed-off-by: German <german@Germans-MacBook-Pro.local>
reactor build with no flags requires an on-disk Dockerfile; neither example ships one, so the documented reactor build / reactor run commands fail with "dockerfile not found". Both READMEs now pass --no-dockerfile, matching how the workspace actually builds. Signed-off-by: German <german@Germans-MacBook-Pro.local>
tempusfrangit
approved these changes
Aug 27, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
reactor build --no-dockerfileno longer derives the runtime's pip install fromreactor.yaml'sbuild.runtime_versionalone. Running either example with the currentreactorCLI fails withModuleNotFoundError: No module named 'reactor_runtime', because the generated image never installs the runtime package.What Changed
Added
reactor-runtime==3.2.4to bothexamples/brightness/requirements.txtandexamples/echo/requirements.txt, matching the patternreactor initscaffolds today (an exact pin inrequirements.txt, kept in sync withbuild.runtime_version). Also added theapiVersion: v1beta/kind: VideoModelheader to bothreactor.yamlfiles, whichreactor doctorflags as missing otherwise.Verified both examples build and run cleanly end to end (
reactor build --no-dockerfile && reactor run),/healthreportinghealthyand the model loading with its expected tracks/commands.🤖 Generated with Claude Code