Bump OrtVersion to 1.29.0 to match onnxruntime_go v1.33.0 - #11
Merged
Conversation
The go-dependencies group bump (#8) took onnxruntime_go from 1.31.0 to 1.33.0 without bumping OrtVersion alongside it, breaking the coupling the constant's own comment warns about. onnxruntime_go v1.33.0 vendors ORT_API_VERSION 29, so any binary built since #8 merged fails on inference against the 1.26.0 library `semantic init` downloads: The requested API version [29] is not available, only API versions [1, 26] are supported in this build. Nothing caught it because the affected tests skip when no model is installed, and shipped straight into the v0.2.0 release. ORT 1.29.0 is the release that defines ORT_API_VERSION 29; confirmed prebuilt archives exist for every platform this repo downloads for. Also note the coupling next to the dependabot group that broke it, so a reviewer of the next grouped bump knows to check for it. Signed-off-by: John Sabath <john@reactor.inc>
This was referenced Aug 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
OrtVersionfrom 1.26.0 to 1.29.0, matching the ORT releaseonnxruntime_gov1.33.0 is built against.onnxruntime_gomoved 1.31.0 → 1.33.0 in #8, a grouped dependency PR, without a matchingOrtVersionbump — breaking the coupling the constant's own comment names. That binding now vendorsORT_API_VERSION 29, whileOrtVersionstill pointedsemantic initat the 1.26.0 library (API 26), so any binary built since #8 merged fails on real inference:It shipped straight into v0.2.0 — nothing in CI catches it, since the real-model tests skip when no model is installed. Also added a comment on the dependabot
go-dependenciesgroup, the mechanism that let this slip through unreviewed, so the next grouped bump gets checked for it.Proved by reproducing the crash pre-fix, then running
semantic init+ a realsearchpost-fix. Full suite — including the real-model and E2E tests, which only execute once the model's installed — passes with 0 skips; lint/deps/licenses clean.