Skip to content

Conversation

@MuhammadRahman-awin
Copy link

No description provided.

*/
final class Prefix implements Gtin\Specification
{
private const ADDITIONAL_VALID_PREFIXES = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MuhammadRahman-awin, thank you for the PR!
Could you please let us know the source of this information?
For example, the GS1 country prefixes are listed here: https://www.gs1.org/standards/id-keys/company-prefix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jafarili, I was curious about progress as we asked for it and saw this question. This link was shared as the source in the slack chat leading to this PR. I double checked now. You can find them at the bottom of the page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FabianSchulcz, the source you've linked doesn't seem to be legit, our source for GTIN prefix is the GS1 official website.
On the link I shared it is stated:

Prefixes not explicitly listed above are reserved by GS1 Global Office for future use.

Which means to me that they are currently not active and valid, but reserved for the future.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jafarili, thanks for pointing that out. We’re aware that these fields are intended for future use. However, they are currently valid according to Google’s feed specifications, and we’ve seen them actively used in production stores on Shopify. Our app generates Google-compatible feeds, so we’ve included support for these fields to ensure compatibility with existing and future implementations.
Looking forward to your reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants