Make new TLD fields nullable as the API doesn't always return them#81
Closed
koenhendriks wants to merge 2 commits into
Closed
Make new TLD fields nullable as the API doesn't always return them#81koenhendriks wants to merge 2 commits into
koenhendriks wants to merge 2 commits into
Conversation
Member
|
Thank you for the pullrequest, unfortunately we made an error in the naming of the fields in the phpclient, we are also fixing this in #82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #80 which currently breaks the TLD info API implementation because the fields are non nullable but are not (always) returned by the actual API.
A test has been added that confirms the bug and its solution.