Skip to content

RT-17796 Fix wdrp/errp field errors #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbrag merged 1 commit into from
May 4, 2026
Merged

RT-17796 Fix wdrp/errp field errors #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/Domain/TLDMetaData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ final class TLDMetaData implements DomainObjectInterface

public ?LaunchPhaseCollection $launchPhases;

public bool $wdrpNotifications;
public ?bool $sendWdrpNotifications;

public bool $errpNotifications;
public ?bool $sendErrpNotifications;

public ?int $transferLockDays;

Expand Down Expand Up @@ -149,8 +149,8 @@ private function __construct(
?string $termsOfService,
?string $privacyPolicy,
string $premiumSupport,
bool $wdrpNotifications,
bool $errpNotifications,
?bool $sendWdrpNotifications,
?bool $sendErrpNotifications,
?int $transferLockDays,
string $renewalOnTransfer,
?string $registrationNotice,
Expand Down Expand Up @@ -196,8 +196,8 @@ private function __construct(
$this->termsOfService = $termsOfService;
$this->privacyPolicy = $privacyPolicy;
$this->premiumSupport = $premiumSupport;
$this->wdrpNotifications = $wdrpNotifications;
$this->errpNotifications = $errpNotifications;
$this->sendWdrpNotifications = $sendWdrpNotifications;
$this->sendErrpNotifications = $sendErrpNotifications;
$this->transferLockDays = $transferLockDays;
$this->renewalOnTransfer = $renewalOnTransfer;
$this->registrationNotice = $registrationNotice;
Expand Down Expand Up @@ -264,8 +264,8 @@ public static function fromArray(array $json): TLDMetaData
$json['termsOfService'] ?? null,
$json['privacyPolicy'] ?? null,
$json['premiumSupport'],
$json['wdrpNotifications'],
$json['errpNotifications'],
$json['sendWdrpNotifications'],
$json['sendErrpNotifications'],
$json['transferLockDays'] ?? null,
$json['renewalOnTransfer'],
$json['registrationNotice'] ?? null,
Expand Down Expand Up @@ -308,8 +308,8 @@ public function toArray(): array
'whoisExposure' => $this->whoisExposure,
'gdprCategory' => $this->gdprCategory,
'premiumSupport' => $this->premiumSupport,
'wdrpNotifications' => $this->wdrpNotifications,
'errpNotifications' => $this->errpNotifications,
'sendWdrpNotifications' => $this->sendWdrpNotifications,
'sendErrpNotifications' => $this->sendErrpNotifications,
'transferLockDays' => $this->transferLockDays,
'domainSyntax' => $this->domainSyntax->toArray(),
'nameservers' => $this->nameservers->toArray(),
Expand Down
4 changes: 2 additions & 2 deletions tests/Domain/data/metadata/metadata_unknown_feature.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
'whoisExposure' => '',
'gdprCategory' => '',
'premiumSupport' => 'REGULAR',
'wdrpNotifications' => false,
'errpNotifications' => false,
'sendWdrpNotifications' => false,
'sendErrpNotifications' => false,
'transferLockDays' => 0,
'domainSyntax' => ['minLength' => 1, 'maxLength' => 64, 'idnSupport' => false], // DomainSyntax
'nameservers' => ['min' => 0, 'max' => 13, 'required' => false], // Nameservers
Expand Down
3 changes: 1 addition & 2 deletions tests/Domain/data/metadata/metadata_valid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
'whoisExposure' => 'FULL',
'gdprCategory' => 'EU_BASED',
'premiumSupport' => 'REGULAR',
'wdrpNotifications' => false,
'errpNotifications' => false,
'sendWdrpNotifications' => false,
'transferLockDays' => 0,
'domainSyntax' => ['minLength' => 1, 'maxLength' => 64, 'idnSupport' => false], // DomainSyntax
'nameservers' => ['min' => 0, 'max' => 13, 'required' => false], // Nameservers
Expand Down
4 changes: 2 additions & 2 deletions tests/Domain/data/tldinfo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
'whoisExposure' => 'NONE',
'gdprCategory' => 'EU_BASED',
'premiumSupport' => 'REGULAR',
'wdrpNotifications' => false,
'errpNotifications' => false,
'sendWdrpNotifications' => false,
'sendErrpNotifications' => false,
'transferLockDays' => 0,
'domainSyntax' => include __DIR__ . '/domains/domain_syntax.php',
'nameservers' => include __DIR__ . '/nameservers.php',
Expand Down
4 changes: 2 additions & 2 deletions tests/Domain/data/tldinfo_com.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,8 +464,8 @@
"registrantChangeApprovalRequired": true,
"allowDesignatedAgent": "BOTH",
"validationCategory": "General",
"wdrpNotifications": false,
"errpNotifications": false,
"sendWdrpNotifications": false,
"sendErrpNotifications": false,
"transferLockDays": 0,
"renewalOnTransfer": "NO_CHANGE",
"registrationNotice": "This is a registration notice!",
Expand Down
4 changes: 2 additions & 2 deletions tests/Domain/data/tldinfo_nl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@
"organizationRequired": false,
"organizationAllowed": true
},
"wdrpNotifications": false,
"errpNotifications": true,
"sendWdrpNotifications": false,
"sendErrpNotifications": true,
"transferLockDays": 0,
"renewalOnTransfer": "RENEW_UNLESS_GRACE",
"registrantChangeTransferLock": false,
Expand Down