Skip to content

Add test for nullable fields in TLD info response #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbrag merged 2 commits into from
May 4, 2026
Merged

Add test for nullable fields in TLD info response #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc61b5c
Add test for `.com` TLD API nullable fields configuration. confirming…
koenhendriks May 4, 2026
7664398
Add non-nullable items after upstream changes.
koenhendriks May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/Clients/Domains/TLDsApiInfoTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,22 @@ public function test_info_com(): void
Assert::assertSame(113, $languageCodes->count());
}

public function test_info_com_nullables(): void
{
$json = file_get_contents(__DIR__ . '/../../Domain/data/tldinfo_com-nullables.json');

assert(is_string($json));

$sdk = MockedClientFactory::makeSdk(
200,
$json,
MockedClientFactory::assertRoute('GET', 'v2/tlds/com/info', $this)
);

$response = $sdk->tlds->info('com');
$this->assertInstanceOf(TLDInfo::class, $response);
}

public function test_info_nl(): void
{
$json = file_get_contents(__DIR__ . '/../../Domain/data/tldinfo_nl.json');
Expand Down
93 changes: 93 additions & 0 deletions tests/Domain/data/tldinfo_com-nullables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
{
"metadata": {
"renewDomainPeriods": [
12,
24,
36,
48,
60,
72,
84,
96,
108,
120
],
"whoisExposure": "FULL",
"gdprCategory": "UNKNOWN",
"createDomainPeriods": [
12,
24,
36,
48,
60,
72,
84,
96,
108,
120
],
"autoRenewDomainPeriods": [
12
],
"registrant": {
"organizationRequired": false,
"organizationAllowed": true
},
"adjustableAuthCode": true,
"creationRequiresPreValidation": false,
"transferFOA": true,
"featuresAvailable": [
"RESTORE",
"CREATE",
"PRIVACY_PROTECT",
"RENEW",
"TRANSFER",
"UPDATE"
],
"customAuthcodeSupport": true,
"adminContacts": {
"min": 1,
"max": 10,
"required": true,
"organizationRequired": false,
"organizationAllowed": true
},
"billingContacts": {
"min": 0,
"max": 10,
"required": false,
"organizationRequired": false,
"organizationAllowed": true
},
"techContacts": {
"min": 1,
"max": 10,
"required": true,
"organizationRequired": false,
"organizationAllowed": true
},
"nameservers": {
"min": 0,
"max": 10,
"required": false
},
"domainSyntax": {
"minLength": 3,
"maxLength": 63,
"idnType": "UTS46",
"idnSupport": true
},
"transferRequiresAuthcode": true,
"transferSupportsAuthcode": true,
"registrantChangeApprovalRequired": true,
"registrantChangeTransferLock": false,
"renewalOnTransfer": "NO_CHANGE",
"restoreIncludesRenew": false,
"premiumSupport": "NO"
},
"provider": "Verisign",
"applicableFor": [
"com",
"net"
]
}