Skip to content

feat(Domain): Renew optional expiry date field #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jesse-rtr wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

feat(Domain): Renew optional expiry date field #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/models/Domain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ export interface IDomainRenew {
domainName: string
period: number
billables?: IBillableDomain[]
expiryDate?: Date
}

export interface IDomainRestore {
Expand Down
2 changes: 1 addition & 1 deletion src/resources/DomainApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export default class DomainApi extends Base {
* @param quote - If true, validate the request and request a quote for the action. Renew will not be executed.
*/
async renew (data: IDomainRenew, quote?: boolean): Promise<DomainRenewProcessResponse | Quote> {
const fields = (({ period, billables }) => ({ period, billables }))(data)
const fields = (({ period, billables, expiryDate }) => ({ period, billables, expiryDate }))(data)
return this.axios.post('/domains/' + data.domainName + '/renew', fields, { params: quote ? { quote: true } : undefined })
.then(response => quote ? new Quote(response.data.quote) : new DomainRenewProcessResponse(response))
}
Expand Down