Add Windows build support#4
Open
fatbob01 wants to merge 8 commits into
Open
Conversation
- Switch build job runner from ubuntu-latest to windows-latest so the net8.0-windows TFM (needed for Radarr.Windows.dll) can be compiled - Uncomment win-x64/win-x86 PackageTests and Package calls in build.sh - Publish win-x64 test artifact and build_windows artifact from build job - Download Windows artifact in release job and zip it alongside Linux tarballs - Include windows-core-x64/x86 zips in GitHub release upload Linux tarballs and Docker image are unaffected; .NET 8 cross-compiles all Linux RIDs from the Windows runner identically to before. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4.15.1 has a known moderate severity vulnerability (GHSA-9j88-vvj5-vhgr) which fails the build because TreatWarningsAsErrors=true promotes NU1902 to a hard error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add Windows build support
The Get Previous Release step fails on first-ever release since there is nothing to compare against. Mark it continue-on-error and make the release notes script omit previous_tag_name when the step produced no output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The release and docker jobs were conditioned on github.event_name == push, which skips them when the workflow is triggered manually. Adding workflow_dispatch so manual runs on develop/master also publish a release. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add INNOVERSION=7.0.0 to global env - Set MAJORVERSION and MINORVERSION env vars needed by radarr.iss - Add --installer flag to build step to run Inno Setup after packaging - Upload installer artifact from distribution/windows/setup/output/ - Download and attach installers alongside zips in the release job Produces Radarr.*.win-x64-installer.exe and win-x86-installer.exe in GitHub releases, matching the pattern used by the Sonarr fork. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
7.0.0 is still in beta and uses a different filename format (innosetup-7.0.0-beta-x86.exe) that doesn't match what build.sh expects, causing a 404 and a broken download. 6.7.2 is the latest stable release with the correct filename pattern. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Runs daily and serves no purpose on a personal fork. Just generates failure emails. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds Windows build support to the GitHub Actions workflow, including proper
.exeinstallers.Changes
build.shwin-x64/win-x86packaging lines that were previously disabled--installerflag to build the Inno Setup.exeinstaller.github/workflows/build.ymlubuntu-latesttowindows-latest— required so thenet8.0-windowsTFM (needed forRadarr.Windows.dll) can be compiledMAJORVERSION,MINORVERSION, andINNOVERSION(6.7.2 stable) env vars for the installerbuild_windowsandbuild_windows_installerartifactswindows-core-x64.zip,windows-core-x86.zip, and.exeinstallers to the GitHub releasesrc/NzbDrone.Core/Radarr.Core.csproj4.15.1to4.16.0to fix a build-breaking NuGet vulnerability (GHSA-9j88-vvj5-vhgr) thatTreatWarningsAsErrors=truepromotes to a hard errorNo impact on Linux/Docker users
.NET 8 cross-compiles all Linux RIDs from the Windows runner identically to before. Docker build job and Linux tarballs are completely unchanged.
Verified
Full CI passed on
fatbob01/Radarrincluding the.exeinstaller: https://github.com/fatbob01/Radarr/actions