fix(windows): decode Windows bash output encodings - #90
Open
yuczzzzz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Windows, some bash commands produce output bytes in a non-UTF-8 encoding. Decoding those bytes as UTF-8 produces garbled text, making command output difficult to read and use.
Goal
Ensure bash output on Windows is correctly decoded as Unicode text when it uses a supported non-UTF-8 encoding, while preserving existing UTF-8 behavior and non-Windows behavior.
Summary
chardetandiconv-lite.Security Impact
This change affects shell-output decoding only. It does not change bash command permissions, execution modes, MCP parameters, environment variables, or result fields. Output retention remains bounded by the existing raw-byte limit. Low-confidence or unsupported encoding detection falls back to the existing UTF-8 behavior.
Validation
npm run buildnpm run smokenpm run stressREADME.mdorCHANGELOG.mdfor this behavior change.