Make lane actions match the dmux cockpit menu#511
Merged
Conversation
The cockpit control frame previously reused the broader pane-menu defaults, which left extra actions and old hotkeys in the selected-lane path. The menu wrapper now exposes the requested lane actions and the control frame centers the menu as an overlay while continuing to return action intents instead of executing them. Constraint: User limited edits to cockpit menu/control and related tests Rejected: Editing src/cockpit/pane-menu.js | it still backs older pane-menu contracts and direct tests Confidence: high Scope-risk: narrow Directive: Keep selected-lane menu hotkeys aligned with src/cockpit/menu.js before changing control help text Tested: node --test test/cockpit-menu.test.js test/cockpit-control.test.js test/cockpit-kitty-integration.test.js Tested: npm test Co-authored-by: OmX <omx@oh-my-codex.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).