[CodeQuality] Fix TypedPropertyFromColumnTypeRector numeric default on decimal/bigint - #522
Merged
Merged
Conversation
…n decimal/bigint string type Doctrine decimal and bigint map to a PHP string. A numeric default like 0 stays an int, producing a fatal 'Cannot use int as default value for property of type string'. Convert the numeric default to its string form, eg: 0 to '0'. Fixes rectorphp/rector#9894 Claude-Session: https://claude.ai/code/session_018nXn7xBmuX9jrY8zZqgAxp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doctrine
decimalandbigintmap to a PHPstring(see Doctrine basic mapping).When such a property has a numeric default, the rule set the
stringtype but left the int default, producing a fatal error:Now the numeric default is converted to its string form:
Fixes rectorphp/rector#9894
https://claude.ai/code/session_018nXn7xBmuX9jrY8zZqgAxp