[CodeQuality] Make property nullable when null default present in TypedPropertyFromColumnTypeRector - #523
Merged
Conversation
TomasVotruba
force-pushed
the
fix-typed-property-null-default-non-nullable
branch
from
September 8, 2026 17:13
3fdcad9 to
b724ec5
Compare
…edPropertyFromColumnTypeRector A property with a `= null` default must be nullable, regardless of the `nullable=false` column mapping. Add null to the resolved type instead of touching the default. Fixes rectorphp/rector#9896
TomasVotruba
force-pushed
the
fix-typed-property-null-default-non-nullable
branch
from
September 8, 2026 19:15
b724ec5 to
b8c86ec
Compare
TomasVotruba
changed the title
TomasVotruba
deleted the
fix-typed-property-null-default-non-nullable
branch
September 8, 2026 19:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A property with a
= nulldefault must be nullable. WhenTypedPropertyFromColumnTypeRectortyped such a property from anullable=falsecolumn, it produced a non-nullable type with a= nulldefault - a fatal error.The default is the source of truth here: if a property defaults to
null, the resolved type is made nullable regardless of the column mapping. The default value is left untouched.Fixes rectorphp/rector#9896