[CodeQuality] Add WillReturnCallbackFallbackToReturnFalseRector - #784
Merged
TomasVotruba merged 1 commit intoSep 17, 2026
Merged
Conversation
…d return false fallback on bool willReturnCallback()
TomasVotruba
deleted the
add-will-return-callback-return-false-fallback
branch
September 17, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a code quality rule that appends a
return false;fallback to awillReturnCallback()closure that only returns booleans but can fall through without a return.Before:
After:
Rule triggers only when every explicit return in the closure returns
true/falseand the body does not already end with a return. Registered in thephpunit-code-qualityset.Note: sibling
WillReturnCallbackFallbackToThrowRectorcovers the same missing-fallback shape but throws; it is deprecated. This one targets the common bool-returning mock case with a concrete default.