[CodeQuality] Skip AddNameToBooleanArgumentRector and AddNameToNullArgumentRector on @no-named-arguments callee - #8508
Merged
Conversation
…gumentRector on @no-named-arguments callee CallLikeArgumentNameAdder now returns early unless the callee accepts named arguments, so both rules leave calls to @no-named-arguments functions and methods alone. Naming those arguments made PHPStan report argument.named.
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9907
AddNameToBooleanArgumentRectorandAddNameToNullArgumentRectornamed arguments even when the callee is marked@no-named-arguments. For example,PhpCsFixer\Config::setRiskyAllowed(true)becamesetRiskyAllowed(isRiskyAllowed: true). PHPStan then reportsargument.named, and removing the name by hand doesn't stick, because Rector adds it back.CallLikeArgumentNameAdder, which both rules use, now returns early unless the callee'sacceptsNamedArguments()isyes(). PHPStan exposes that onFunctionReflectionandExtendedMethodReflection, so theinstanceofcheck narrows fromMethodReflectiontoExtendedMethodReflection. The method reflections thatMethodReflectionResolverreturns already are one, so nothing that worked before is skipped.Each rule gets a
skip_no_named_argumentsfixture that covers a method call, a static call andnewon a@no-named-argumentsclass.