Skip to content

[Symfony30] Reuse existing untyped $request param in GetRequestRector - #1066

Merged
TomasVotruba merged 1 commit into
mainfrom
reuse-untyped-request-param
Sep 16, 2026
Merged

TomasVotruba merged 1 commit into
mainfrom
reuse-untyped-request-param

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

GetRequestRector added a new Request $request param whenever a @Route action used $this->getRequest(). If the action already had an untyped $request param, the rule renamed the new one to $mainRequest (via resolveUniqueName), producing two request params - one of them dead:

public function someAction($request, Request $mainRequest)

Now the rule reuses an existing untyped $request param and just adds the type:

public function someAction(Request $request)

An already-typed $request (different type) keeps the previous rename behavior, so existing fixtures stay green. New fixture covers the untyped case.

@TomasVotruba
TomasVotruba merged commit 01d10ed into main Sep 16, 2026
7 checks passed
@TomasVotruba
TomasVotruba deleted the reuse-untyped-request-param branch September 16, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant