[Symfony30] Reuse existing untyped $request param in GetRequestRector - #1066
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetRequestRector added a new
Request $requestparam whenever a@Routeaction used$this->getRequest(). If the action already had an untyped$requestparam, the rule renamed the new one to$mainRequest(viaresolveUniqueName), producing two request params - one of them dead:Now the rule reuses an existing untyped
$requestparam and just adds the type:An already-typed
$request(different type) keeps the previous rename behavior, so existing fixtures stay green. New fixture covers the untyped case.