Drop symfony/finder, reuse Entropy FileFinder - #140
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
remove-symfony-finder
branch
2 times, most recently
from
September 17, 2026 22:03
47dbd0b to
c89769f
Compare
TomasVotruba
force-pushed
the
remove-symfony-finder
branch
from
September 17, 2026 22:16
c89769f to
1853a14
Compare
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
symfony/finderfrom productionrequire. Our commands relied on Symfony'sFinderengine and itsSplFileInfo(forgetContents(),getRelativePathname(),getRelativePath()).Replaced with the generic finder added to entropy in entropy#23, released as Entropy 0.4.14:
Entropy\FileSystem\FileFinder::find(array $directories, ?callable $filter): FileInfo[]- recursive scanner returning files with paths relative to the scanned directory.Entropy\FileSystem\FileInfo- extends native\SplFileInfo, addsgetContents(),getRelativePathname(),getRelativePath(). Same API as Symfony's, so call sites stay unchanged.FilesFinder,PhpFilesFinder,TraitFilesFinder,NamespaceToPSR4CommandandTestsDirectoryResolvernow build on it.node_modules/vendor/varskips match the relative path (as Symfony'snotPathdid), not the absolute path.Requires
entropy/entropy ^0.4.14.symfony/finderremains only as a transitive dev dependency ofclass-leak.Tests, PHPStan, ECS, Rector all green locally.