Drop alice-yaml-fixtures-to-php command and symfony/yaml

README.md

@@ -233,21 +233,7 @@ Searching for regex: #this->get\((.*)\)#
 
 <br>
 
-## 8. Convert Alice fixtures from YAML to PHP
-
-The `nelmio/alice` package [allows to use PHP](https://github.com/nelmio/alice/blob/v2.3.0/doc/complete-reference.md#php) for test fixture definitions. It's much better format, because Rector and PHPStan can understand it.
-
-But what if we have 100+ YAML files in our project?
-
-```bash
-vendor/bin/swiss-knife convert-alice-yaml-to-php fixtures
-```
-
-That's it!
-
-<br>
-
-## 9. Spots Fake Traits
+## 8. Spots Fake Traits
 
 What is trait has 5 lines and used in single service? We know it's better to be inlined, to empower IDE, Rector and PHPStan. But don't have time to worry about these details.
 
@@ -269,7 +255,7 @@ That's it! Run this command once upon a time or run it in CI to eliminate traits
 
 <br>
 
-## 10. Split huge Symfony config to per-package in directory
+## 9. Split huge Symfony config to per-package in directory
 
 Do you have a huge Symfony config file that is hard to navigate? Do you want to split it to per-package files?
 
@@ -345,7 +331,7 @@ All the extensions will be extracted to separate files in `config/packages/dev`
 
 <br>
 
-## 11. Generate Symfony Smoke Tests
+## 10. Generate Symfony Smoke Tests
 
 Cover your Symfony app with smoke tests in seconds. This command scans your `composer.json`, picks the matching test templates, and drops them under `tests/Unit/Smoke` (or your project's equivalent unit-tests directory).
 
@@ -420,7 +406,7 @@ final class ServiceContainerTest extends AbstractContainerTestCase
 
 <br>
 
-## 12. Detect Duplicated Code
+## 11. Detect Duplicated Code
 
 Spot copy-pasted code blocks with a token-based detector, a small clone of phpcpd.
 Add it to CI to fail when a large copy-pasted block is added:

composer.json

@@ -13,7 +13,6 @@
         "nette/utils": "^4.1",
         "nikic/php-parser": "^5.7",
         "symfony/finder": "^8.1",
-        "symfony/yaml": "^8.1",
         "webmozart/assert": "^2.4"
     },
     "require-dev": {

src/Command/NamespaceToPSR4Command.php

@@ -12,6 +12,9 @@
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Finder\SplFileInfo;
 
+/**
+ * @see \Rector\SwissKnife\Tests\Command\NamespaceToPSR4CommandTest
+ */
 final readonly class NamespaceToPSR4Command implements CommandInterface
 {
     public function __construct(

src/Finder/FilesFinder.php

@@ -8,6 +8,9 @@
 use Symfony\Component\Finder\SplFileInfo;
 use Webmozart\Assert\Assert;
 
+/**
+ * @see \Rector\SwissKnife\Tests\Finder\FilesFinderTest
+ */
 final class FilesFinder
 {
     /**

src/Finder/PhpFilesFinder.php

@@ -8,6 +8,9 @@
 use Symfony\Component\Finder\SplFileInfo;
 use Webmozart\Assert\Assert;
 
+/**
+ * @see \Rector\SwissKnife\Tests\Finder\PhpFilesFinderTest
+ */
 final class PhpFilesFinder
 {
     /**

src/PhpParser/NodeVisitor/FindNonPrivateClassConstNodeVisitor.php

@@ -71,7 +71,7 @@ private function isConstantDefinedInParentClassAlso(Class_ $class, string $const
 
         return array_any(
             $class->implements,
-            fn ($implement): bool => in_array($constantName, $this->getClassConstantNames($implement->toString()), true)
+            fn (Name $name): bool => in_array($constantName, $this->getClassConstantNames($name->toString()), true)
         );
     }
 

src/SmokeTestgen/FileSystem/TestsDirectoryResolver.php

@@ -12,10 +12,8 @@ public function resolveSmokeUnitTestDirectory(string $projectDirectory): string
     {
         $testDirectory = $this->resolveTestDirectory($projectDirectory);
 
-        if ($testDirectory === null) {
-            // fallback to default
-            $testDirectory = 'tests';
-        }
+        // fallback to default
+        $testDirectory ??= 'tests';
 
         $unitTestDirectory = $this->resolveUnitTestsDirectory($testDirectory);
         if ($unitTestDirectory === null) {

src/SmokeTestgen/TestTemplateResolver.php

@@ -31,8 +31,7 @@ public function matchProjectPackages(array $requiredPackages): array
         // find all subscribers, that match any of the required packages
         return array_filter(
             $this->testByPackageSubscribers,
-            fn (TestByPackageSubscriberInterface $testByPackageSubscriber): bool =>
-                array_intersect($testByPackageSubscriber->getPackageNames(), $requiredPackages) !== []
+            fn (TestByPackageSubscriberInterface $testByPackageSubscriber): bool => array_intersect($testByPackageSubscriber->getPackageNames(), $requiredPackages) !== []
         );
     }
 }

src/SmokeTestgen/Utils/TestPathResolver.php

@@ -6,6 +6,9 @@
 
 use Rector\SwissKnife\SmokeTestgen\Contract\TestByPackageSubscriberInterface;
 
+/**
+ * @see \Rector\SwissKnife\Tests\SmokeTestgen\Utils\TestPathResolverTest
+ */
 final class TestPathResolver
 {
     public static function resolve(

src/Testing/UnitTestFilter.php

@@ -33,7 +33,7 @@ private function isUnitTest(string $class): bool
 
         return array_all(
             self::NON_UNIT_TEST_CASE_CLASSES,
-            fn ($nonUnitTestCaseClass): bool => ! is_a($class, $nonUnitTestCaseClass, true)
+            fn (string $nonUnitTestCaseClass): bool => ! is_a($class, $nonUnitTestCaseClass, true)
         );
     }
 }