Conversation
Prevent denial-of-service via oversized webhook payloads by limiting the request body read to 2MB using io.LimitReader. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
When MustUseReference() is true, users could override security-sensitive WorkflowSpec fields (ServiceAccountName, SecurityContext, Volumes, etc.) via workflowTemplateRef submissions. Replace the single podSpecPatch deny-check with allow-list validation that rejects non-allowed fields, plus defense-in-depth sanitization before the strategic merge patch. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Update vulnerable dependencies: - golang.org/x/crypto: v0.36.0 → v0.52.0 - golang.org/x/net: v0.38.0 → v0.55.0 - github.com/go-jose/go-jose/v3: v3.0.4 → v3.0.5 - google.golang.org/grpc: v1.71.1 → v1.79.3 Cherry-picked from rhoai-3.3 PR argoproj#720. Signed-off-by: Nelesh Singla <117123879+nsingla@users.noreply.github.com>
github-actions
Bot
removed
the
run-gatekeeper
Post-Codefreeze Gatekeeper — FAILED (evaluation)
Target branch: ❌ The following issues were found:
After resolving issues, push a commit, re-edit the PR description, or add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports CVE fixes to rhoai-3.5 branch (cherry-picked from rhoai-3.3 PR #720):
io.LimitReaderinserver/auth/webhook/interceptor.goworkflow/controller/operator.go+ defense-in-depth sanitization inworkflow/util/merge.goTest plan
go build ./...succeedsgo test ./...— all existing tests pass