fix(ci): enable trailing whitespace checks - #318
Merged
SigureMo merged 1 commit intoSep 15, 2026
Merged
Conversation
ooooo-create
requested review from
NINGBENZHE,
Yangruipis and
yxyOo
as code owners
September 15, 2026 14:48
# 🐛 Bug Fix - Set trailing-whitespace to the inline YAML list `types_or: [python, yaml, json, shell, c, proto]` so files match any configured language tag instead of requiring every tag. - Remove trailing whitespace from 33 lines across 11 shell scripts so the newly enabled check passes on all tracked files. - Preserve the language list and transfer_queue exclusion. ## Validation - pre-commit run --all-files --show-diff-on-failure: passed - prek run --all-files: passed - trailing-whitespace: (no files to check)Skipped before, Passed after - bash -n: passed for all 11 changed shell scripts
ooooo-create
force-pushed
the
fix/trailing-whitespace-types-or
branch
from
September 15, 2026 14:52
c529fa8 to
25666e2
Compare
Nyanpasu 审查看板审查状态: ✅ 已通过 审查版本: 已完成 12 个文件的审查,未发现需修改的问题。11 个脚本的 33 行改动均仅清理行尾空白;本地 bash -n、git diff --check 通过,CI 全仓库 Pre-commit Checks 通过。Python 3.10–3.12 测试仍在运行;本地未运行 pytest,无多节点 GPU 硬件,未执行硬件集成测试。 没有未解决的审查问题。
Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.
|
rai-studio-bot
approved these changes
Sep 15, 2026
rai-studio-bot
left a comment
There was a problem hiding this comment.
已完成对 25666e2 的审查,未发现需要修改的问题,同意合入。types_or 符合官方 OR 筛选语义,并保留上游 text 筛选和现有目录排除。
本地确认 11 个脚本仅清理 33 行行尾空白,bash -n 与 git diff --check 均通过;CI Pre-commit Checks 已通过。Python 3.10–3.12 测试仍在运行。本地未运行 pytest;本次为配置和空白修复,多节点 GPU 集成测试因无相应硬件未执行。
Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
trailing-whitespacerun on the configured file types instead of reporting(no files to check)Skipped, using a single-linetypes_orlist. After the fix and cleanup, it reportsPassed.Why
typescombines tags with AND, so a file had to matchpython,yaml,json,shell,c, andprotosimultaneously. No files matched, even with--all-files, leaving trailing whitespace unchecked.How
types_or: [python, yaml, json, shell, c, proto]to match any of the six language tags. Keep the existing language list, inherited text filter, andtransfer_queue/exclusion.Testing
pre-commit run --all-filespassespytest tests/)Validation details:
pre-commit run --all-files --show-diff-on-failureandprek run --all-files: all hooks passed, includingtrailing-whitespace.bash -n: passed for all 11 changed shell scripts.git diff --check: passed.pytest tests/: not run locally because the changes are limited to hook filtering and trailing whitespace. GPU integration tests require multi-node GPU hardware and were not run.Type of Change
Screenshots / Logs
Actual terminal output from the same command before and after the fix (prek 0.5.2):
Before — original configuration:
After — fixed configuration and existing whitespace cleaned up:
The first run after correcting the filter found and fixed the 11 scripts, returning
Failedbecause files were modified. The output above is from the successful rerun with those cleanups included.