fix(npu): remove entrypoint trailing whitespace - #319
Merged
Conversation
Remove the comment's trailing space in local-npu-multinode.sh so the trailing-whitespace hook no longer modifies the checkout in CI. Failed run: https://github.com/redai-studio/Relax/actions/runs/35052178735
Nyanpasu 审查看板审查状态: ✅ 已通过 审查版本: 复核完成,维持批准,无新增发现。目标提交仅删除注释末尾空格。首次 Python 3.10 失败日志与既有测试在 shuffle 后才安装警告捕获的竞态一致,与本次变更无关。CI 已重跑:Pre-commit、Python 3.11/3.12 通过,Python 3.10 仍在运行。本地语法及空白差异检查此前通过;因仅修改注释且无相应硬件,未运行多节点 GPU/NPU 集成测试。 没有未解决的审查问题。
Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.
|
rai-studio-bot
approved these changes
Sep 16, 2026
rai-studio-bot
left a comment
There was a problem hiding this comment.
审查通过。ed62d364 仅删除 shell 注释末尾一个空格,修复与原 CI 失败原因一致。已验证 bash -n、git diff --check 和忽略行尾空白后无差异;当前 Pre-commit CI 通过,Python 3.10/3.11/3.12 测试仍在运行。未运行多节点 GPU/NPU 集成测试:本次仅修改注释,且本地无相应硬件。
Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove one trailing space from the comment at
scripts/entrypoint/local-npu-multinode.sh:81. No executable code, dependencies, generated files, or hook configuration changes.Why
The latest failed CI run #35052178735, triggered by push commit 070391c — feat(NPU): optimizations for Qwen3.5 9B & 35B, failed only in Pre-commit Checks. The new script contains a trailing space;
trailing-whitespaceremoves it and exits 1 because the checkout was modified. All other hooks and the Python 3.10/3.11/3.12 test jobs passed. This is a reproducible source-formatting issue, not an infrastructure or dependency failure.How
Apply exactly the one-line whitespace correction shown in the failed CI log. Keep the existing whitespace check enabled and unchanged.
Testing
pre-commit run --all-files --show-diff-on-failurepasses (pre-commit 4.6.2 under Python 3.10, all 15 hooks).pytest tests/) — not rerun locally for a comment-only edit. PR CI: Python 3.11/3.12 pass; Python 3.10 hits an unrelated existing warning-capture race (details below).Additional validation:
pre-commit run trailing-whitespace --files scripts/entrypoint/local-npu-multinode.sh --show-diff-on-failure: exit 1 before the fix, producing exactly this diff.default_language_version: {python: python3.10}; tracked configuration is unchanged.bash -n scripts/entrypoint/local-npu-multinode.sh,git diff --check, andgit diff --exit-code --ignore-space-at-eolpass.docformatter==1.3.1(Constant.swas removed); validation was rerun successfully with CI's Python 3.10 rather than broadening this fix.PR CI results
CI run #35064362175 for
ed62d364:test_streaming_dataset_missing_media_skip_refills_batch[prefetch]attests/engine/sft/dataset/test_streaming.py:980(job log). The batch-content assertion passes, but the test's warning list is empty. The log contains the expected warning:ds.shuffle(0)starts prefetch before the test monkeypatcheslogger.warning, so the worker can emit the warning before capture is installed. This test and its implementation are identical to the base commit, whose Python 3.10 job passed.Attempted to rerun only the failed job; GitHub refused with
Must have admin rights to Repository. A maintainer rerun is needed. This independent test race is intentionally not bundled into a one-space formatting fix.Type of Change
Screenshots / Logs
The failed job reports: