Skip to content

fix(npu): remove entrypoint trailing whitespace - #319

Merged
SigureMo merged 1 commit into
redai-studio:mainfrom
ShigureNyako:session/sess_dev_neko_investigate_and_remediate_latest_relax_pre_commi
Sep 16, 2026
Merged

SigureMo merged 1 commit into
redai-studio:mainfrom
ShigureNyako:session/sess_dev_neko_investigate_and_remediate_latest_relax_pre_commi

Conversation

@ShigureNyako

@ShigureNyako ShigureNyako commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

What

Remove one trailing space from the comment at scripts/entrypoint/local-npu-multinode.sh:81. No executable code, dependencies, generated files, or hook configuration changes.

Why

The latest failed CI run #35052178735, triggered by push commit 070391c — feat(NPU): optimizations for Qwen3.5 9B & 35B, failed only in Pre-commit Checks. The new script contains a trailing space; trailing-whitespace removes it and exits 1 because the checkout was modified. All other hooks and the Python 3.10/3.11/3.12 test jobs passed. This is a reproducible source-formatting issue, not an infrastructure or dependency failure.

How

Apply exactly the one-line whitespace correction shown in the failed CI log. Keep the existing whitespace check enabled and unchanged.

Testing

  • pre-commit run --all-files --show-diff-on-failure passes (pre-commit 4.6.2 under Python 3.10, all 15 hooks).
  • Tests pass (pytest tests/) — not rerun locally for a comment-only edit. PR CI: Python 3.11/3.12 pass; Python 3.10 hits an unrelated existing warning-capture race (details below).
  • New tests added (if applicable) — not applicable; the existing hook catches this exact regression.
  • Documentation updated (if applicable) — not applicable; no documentation or behavior changes.

Additional validation:

  • Reproduced with pre-commit run trailing-whitespace --files scripts/entrypoint/local-npu-multinode.sh --show-diff-on-failure: exit 1 before the fix, producing exactly this diff.
  • All 15 hooks also pass with CI's prek 0.5.3 using a temporary config that only adds default_language_version: {python: python3.10}; tracked configuration is unchanged.
  • bash -n scripts/entrypoint/local-npu-multinode.sh, git diff --check, and git diff --exit-code --ignore-space-at-eol pass.
  • Local default Python 3.14 cannot build the existing docformatter==1.3.1 (Constant.s was removed); validation was rerun successfully with CI's Python 3.10 rather than broadening this fix.
  • Documentation builds and multi-node GPU/NPU integration runs were not performed: this removes only a comment's trailing space, and no multi-node accelerator hardware is available locally.

PR CI results

CI run #35064362175 for ed62d364:

  • Pre-commit Checks: passed, with the unmodified repository hook configuration.
  • Tests (Python 3.11 / 3.12): passed.
  • Tests (Python 3.10): failed in the unchanged test_streaming_dataset_missing_media_skip_refills_batch[prefetch] at tests/engine/sft/dataset/test_streaming.py:980 (job log). The batch-content assertion passes, but the test's warning list is empty. The log contains the expected warning: ds.shuffle(0) starts prefetch before the test monkeypatches logger.warning, so the worker can emit the warning before capture is installed. This test and its implementation are identical to the base commit, whose Python 3.10 job passed.

Attempted to rerun only the failed job; GitHub refused with Must have admin rights to Repository. A maintainer rerun is needed. This independent test race is intentionally not bundled into a one-space formatting fix.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • CI/CD or build changes

Screenshots / Logs

The failed job reports:

trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing scripts/entrypoint/local-npu-multinode.sh

Remove the comment's trailing space in local-npu-multinode.sh so the
trailing-whitespace hook no longer modifies the checkout in CI.

Failed run: https://github.com/redai-studio/Relax/actions/runs/35052178735
@rai-studio-bot

rai-studio-bot commented Sep 16, 2026

Copy link
Copy Markdown

Nyanpasu 审查看板

审查状态: ✅ 已通过

审查版本: ed62d36430f2a40c9ba9c48137a7274586eb62a9

复核完成,维持批准,无新增发现。目标提交仅删除注释末尾空格。首次 Python 3.10 失败日志与既有测试在 shuffle 后才安装警告捕获的竞态一致,与本次变更无关。CI 已重跑:Pre-commit、Python 3.11/3.12 通过,Python 3.10 仍在运行。本地语法及空白差异检查此前通过;因仅修改注释且无相应硬件,未运行多节点 GPU/NPU 集成测试。

没有未解决的审查问题。

Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.

@rai-studio-bot rai-studio-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

审查通过。ed62d364 仅删除 shell 注释末尾一个空格,修复与原 CI 失败原因一致。已验证 bash -ngit diff --check 和忽略行尾空白后无差异;当前 Pre-commit CI 通过,Python 3.10/3.11/3.12 测试仍在运行。未运行多节点 GPU/NPU 集成测试:本次仅修改注释,且本地无相应硬件。

Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo
SigureMo merged commit 259dbf0 into redai-studio:main Sep 16, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants