Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci(github): add GPU unittest workflow #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(github): add GPU unittest workflow #320
Changes from all commits
db2f18e95fa901effca4bd0018b3eec066264f730fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a fork PR, the checkout contains contributor-controlled code that is executed by
pyteston the persistent self-hosted H20 runner. The container still receives the runner's proxy values and writable shared uv cache, so malicious tests can exfiltrate embedded proxy credentials or poison state consumed by later trusted jobs;contents: readdoes not protect these host resources. Require trusted approval or an allowlist before scheduling fork code, or use an ephemeral isolated runner.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
补充核验:这个 fork PR 的首次运行已经在 H20 runner 上完成 Checkout 并进入宿主机的 Create test container 步骤;缺少
CI_GPU_DEVICES只会让当前脚本退出,并不是执行权限边界。PR 若修改这些run步骤,就能以 runner 账户直接使用 Docker,绕过第 49–64 行设置的 GPU、网络与挂载限制,影响同机另一 runner 及后续任务。建议在启用公开 PR 自动执行前,把整个 runner 放进每次销毁的隔离环境;若保留持久化主机,则需要在 PR 无法修改的调度/runner 访问策略中限制为受信工作流和经审核的提交,单独增加本 YAML 内的条件不足以建立边界。GitHub 的自托管 runner 安全说明也指出了这种持久化风险。当前账户无法读取仓库级 fork 审批策略,因此这里不声称所有外部 PR 都会免审批运行;如已有外部约束,请提供其配置依据以便复核。
Uh oh!
There was an error while loading. Please reload this page.