Skip to content

New v1.5.1 Release - #41

Merged
redddcyclone merged 3 commits into
redddcyclone:mainfrom
glpi-project:release/1.5.1
Sep 18, 2026
Merged

redddcyclone merged 3 commits into
redddcyclone:mainfrom
glpi-project:release/1.5.1

Conversation

@g-bougard

Copy link
Copy Markdown
Contributor

Hi @redddcyclone

here is my PR to synchronize your upstream project with the release I'll include in glpi-agent.

It includes the Ukrainian language add proposed by @turbay-a.

I also changed the rc2 include to limit the need of changes during a release. I also updated the GH Actions building process to support that change: version.h was overridden during the build even if not required. Now it is only overridden if a tag is set.

I also updated most versions on third-party used GH Actions. I leaved the ilammy/msvc-dev-cmd@v1.13.0 one for you as I'm not sure what to do with it but it seems to no more be maintained. It has to be updated as nodejs-20 will no more be supported. Check the warning here: https://github.com/glpi-project/glpi-agentmonitor/actions/runs/35325640040
Indeed Node.js 20 removal is actually planned in 5 days as reported here: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
If the purpose of that action is just to setup msbuild, maybe the more official (and maintained) setup-msbuild could do the job ?
Anyway can you find a solution for future releases (so no urgency) ?

Andrii ADM. Turbay and others added 3 commits September 18, 2026 10:39
Updated Changes
We should set version only in version.h
@redddcyclone

Copy link
Copy Markdown
Owner

Hi @g-bougard, thanks for the PR!

Yes, msvc-dev-cmd is used just for setting up MSBuild. Replacing it with setup-msbuild will likely work just fine. Only the with: arch part must be removed. Can you commit this in this PR?

@g-bougard

Copy link
Copy Markdown
Contributor Author

I prefer you test and validate it and I'll cherry-pick the update. Actually I don't require it until next release.

@redddcyclone

Copy link
Copy Markdown
Owner

OK, I'll do it.

@redddcyclone
redddcyclone merged commit e10bd63 into redddcyclone:main Sep 18, 2026
3 checks passed
@redddcyclone

Copy link
Copy Markdown
Owner

@g-bougard I commited the change to the main branch and looks like everything went fine.

I made a mistake in my local repository though, and ended up losing your commit b469862. I have recommitted the changes manually. Sorry about that.

@g-bougard

Copy link
Copy Markdown
Contributor Author

Thank you,

don't worry for the commit, everything is fine.

I update my repo too with your 2 lasts commits. Thank you ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants