New v1.5.1 Release - #41
Merged
Merged
Conversation
Updated Changes We should set version only in version.h
Owner
|
Hi @g-bougard, thanks for the PR! Yes, |
Contributor
Author
|
I prefer you test and validate it and I'll cherry-pick the update. Actually I don't require it until next release. |
Owner
|
OK, I'll do it. |
Owner
|
@g-bougard I commited the change to the main branch and looks like everything went fine. I made a mistake in my local repository though, and ended up losing your commit b469862. I have recommitted the changes manually. Sorry about that. |
Contributor
Author
|
Thank you, don't worry for the commit, everything is fine. I update my repo too with your 2 lasts commits. Thank you ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @redddcyclone
here is my PR to synchronize your upstream project with the release I'll include in glpi-agent.
It includes the Ukrainian language add proposed by @turbay-a.
I also changed the rc2 include to limit the need of changes during a release. I also updated the GH Actions building process to support that change: version.h was overridden during the build even if not required. Now it is only overridden if a tag is set.
I also updated most versions on third-party used GH Actions. I leaved the
ilammy/msvc-dev-cmd@v1.13.0one for you as I'm not sure what to do with it but it seems to no more be maintained. It has to be updated as nodejs-20 will no more be supported. Check the warning here: https://github.com/glpi-project/glpi-agentmonitor/actions/runs/35325640040Indeed Node.js 20 removal is actually planned in 5 days as reported here: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
If the purpose of that action is just to setup msbuild, maybe the more official (and maintained) setup-msbuild could do the job ?
Anyway can you find a solution for future releases (so no urgency) ?