installer: Guard RHOAI references in confirmation and summary output (#526, #527) - #528
Open
raycarroll wants to merge 5 commits into
Open
installer: Guard RHOAI references in confirmation and summary output (#526, #527)#528raycarroll wants to merge 5 commits into
raycarroll wants to merge 5 commits into
Conversation
…hat-ai-americas#518) The UI deploy script unconditionally ran RHOAI integration steps (proxy route + tile CR) that failed on clusters without RHOAI installed. Consolidate all RHOAI tile logic into the UI script (where it belongs) with namespace and CRD existence guards, add --skip-tile flag support, and remove the redundant deploy_tile() from deploy-full.sh which now passes --skip-tile through to the UI script. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…dhat-ai-americas#518) Same pattern as the deploy fix — check that the RHOAI namespace exists and the OdhApplication CRD is present before attempting tile artifact cleanup. Without this, uninstall-full.sh fails on non-RHOAI clusters because oc delete on a missing resource type is a hard error even with --ignore-not-found. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…le (redhat-ai-americas#518) check-prereqs.sh treated missing RHOAI as a failure, blocking deploy on non-RHOAI clusters. Downgrade to a warning since the only RHOAI integration is the optional dashboard tile. Also fix unbound variable error when SKIP_TILE is false — empty bash arrays trigger set -u with "${arr[@]}" expansion. Use a simple conditional instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…edhat-ai-americas#526, redhat-ai-americas#527) On non-RHOAI clusters, uninstall confirm prompt listed RHOAI tile artifacts that wouldn't be removed, and deploy summary printed a misleading "route not found" for the RHOAI dashboard. Guard both behind namespace-existence checks. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
raycarroll
requested review from
KatyaRomashko,
rdwj and
srampal
as code owners
August 14, 2026 13:40
Collaborator
Author
|
Note that this has not yet been tested on an RHOAI cluster. Can discuss this afternoon |
…americas#526, redhat-ai-americas#527) The summary checklist used bare `echo` for lines with color variables, causing literal \033[...] sequences instead of colored output. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
This has now been tested on RHOAI cluster. please review @rdwj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On non-RHOAI clusters,
uninstall-full.shconfirmation prompt listed RHOAI tile artifacts that wouldn't be removed, anddeploy-full.shsummary printed a misleading "route not found" for the RHOAI dashboard. Guard both behind namespace-existence checks.Follows up on #525 which already guarded
remove_tile()and made RHOAI optional — these are the remaining UI output paths that still assumed RHOAI was present.Linked issues
Closes #526
Closes #527
Design reference
docs/guides/cluster-install.mdType of change
type:feature— new user-visible capabilitytype:bug— fix for incorrect behaviortype:infra— build, CI, deploy, or tooling changetype:design— design doc only, no codeSubsystem
memory-treestoragecuratorgovernancemcp-serveroperatorobservabilityorg-ingestionauthuillamastackChanges
scripts/uninstall-full.shconfirm(): RHOAI tile listing gated behindoc get namespace— on non-RHOAI clusters the artifact list is omitted entirelysummary(): three-way display — "skipped" (--skip-tile), checkmark (RHOAI present), or "(not installed)" (namespace absent)RHOAI_PRESENTflag tracks namespace existence fromconfirm()for use insummary()scripts/deploy-full.shprint_summary(): RHOAI dashboard route query moved inside namespace-existence guard; shows "(not installed)" when namespace absent, preserves "route not found" diagnostic only when RHOAI is installed but route is missingTest plan
Run
deploy-full.shon a non-RHOAI cluster — summary showsRHOAI dashboard: (not installed)Run
deploy-full.shon a RHOAI cluster — summary shows the dashboard URL as beforeRun
uninstall-full.shon a non-RHOAI cluster — confirmation prompt omits RHOAI tile artifacts; summary showsRHOAI tile artifacts (not installed)Run
uninstall-full.sh --skip-tile— summary showsRHOAI tile artifacts (skipped)Golden test (preserve-data):
scripts/uninstall-full.sh --skip-data --yes && scripts/deploy-full.shpytestpasses locally (or the affected subset)Manual verification against a running cluster (if applicable)
New tests added for new behavior
Reviewer checklist
subsystem: Imperative summaryformat🤖 Generated with Claude Code