Skip to content

[release-4.22] OCPBUGS-109673: BC/T-BC os-clock-sync-state stuck LOCKED after upstream loss when phc2sys stops disciplining CLOCK_REALTIME (phc2sysOpts: -a -r) - #735

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-cne:release-4.22from
edcdavid:OCPBUGS-105425-to-release-4.22
Aug 19, 2026
Merged

Conversation

@edcdavid

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #731

/assign edcdavid

Assisted-By: Cursor

…ected

Detect loss of OS-clock discipline from phc2sys selection windows after
upstream loss under -a -r, so E3 does not stay stuck LOCKED when
CLOCK_REALTIME samples stop. Keep a small Stats window + settle timer and
metrics handler; do not restore T-BC→E3 forcing or implement reverse sync.
@openshift-ci-robot

Copy link
Copy Markdown

@edcdavid: Detected clone of Jira Issue OCPBUGS-105425 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.22] OCPBUGS-109673: BC/T-BC os-clock-sync-state stuck LOCKED after upstream loss when phc2sys stops disciplining CLOCK_REALTIME (phc2sysOpts: -a -r)

Details

In response to this:

This is an automated cherry-pick of #731

/assign edcdavid

Assisted-By: Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c4b41c59-a148-474c-b3de-0079d034fbf2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nocturnalastro nocturnalastro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edcdavid, nocturnalastro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edcdavid

Copy link
Copy Markdown
Contributor Author

/jira-refresh

@edcdavid

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@edcdavid: This pull request references Jira Issue OCPBUGS-109673, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-105425 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-105425 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@edcdavid

Copy link
Copy Markdown
Contributor Author

/verified later @hhassid

@openshift-ci-robot

Copy link
Copy Markdown

@edcdavid: This PR has been marked to be verified later by @hhassid.

Details

In response to this:

/verified later @hhassid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@edcdavid

Copy link
Copy Markdown
Contributor Author

/backport-risk-assessed

@edcdavid

Copy link
Copy Markdown
Contributor Author

/label backport-risk-assessed

@openshift-merge-bot
openshift-merge-bot Bot merged commit 9d40ec2 into redhat-cne:release-4.22 Aug 19, 2026
7 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@edcdavid: Jira Issue OCPBUGS-109673: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-109673 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #731

/assign edcdavid

Assisted-By: Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants