Skip to content

[release-4.21] OCPBUGS-109674: BC/T-BC os-clock-sync-state stuck LOCKED after upstream loss when phc2sys stops disciplining CLOCK_REALTIME (phc2sysOpts: -a -r) - #737

Open
edcdavid wants to merge 1 commit into
redhat-cne:release-4.21from
edcdavid:OCPBUGS-105425-to-release-4.21
Open

[release-4.21] OCPBUGS-109674: BC/T-BC os-clock-sync-state stuck LOCKED after upstream loss when phc2sys stops disciplining CLOCK_REALTIME (phc2sysOpts: -a -r)#737
edcdavid wants to merge 1 commit into
redhat-cne:release-4.21from
edcdavid:OCPBUGS-105425-to-release-4.21

Conversation

@edcdavid

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #731

/assign edcdavid

Assisted-By: Cursor

…ected

Detect loss of OS-clock discipline from phc2sys selection windows after
upstream loss under -a -r, so E3 does not stay stuck LOCKED when
CLOCK_REALTIME samples stop. Keep a small Stats window + settle timer and
metrics handler; do not restore T-BC→E3 forcing or implement reverse sync.
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: edcdavid
Once this PR has been reviewed and has the lgtm label, please assign aneeshkp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ac7a84e5-4524-45f0-9ae3-b4429f8d8170

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

Copy link
Copy Markdown

@edcdavid: Jira Issue OCPBUGS-105425 has been cloned as Jira Issue OCPBUGS-109677. Will retitle bug to link to clone.
/retitle [release-4.21] OCPBUGS-109674: BC/T-BC os-clock-sync-state stuck LOCKED after upstream loss when phc2sys stops disciplining CLOCK_REALTIME (phc2sysOpts: -a -r)

Details

In response to this:

This is an automated cherry-pick of #731

/assign edcdavid

Assisted-By: Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nocturnalastro nocturnalastro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@edcdavid

Copy link
Copy Markdown
Contributor Author

/verified later @hhassid

@openshift-ci-robot

Copy link
Copy Markdown

@edcdavid: This PR has been marked to be verified later by @hhassid.

Details

In response to this:

/verified later @hhassid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@edcdavid

Copy link
Copy Markdown
Contributor Author

/label backport-risk-assessed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants