OCPBUGS-111881: Fix T-BC dual-upstream port role metrics - #740
Conversation
Description of problem: Dual-upstream T-BC port metrics are stale after switchover.
First lock - as expected
```
openshift_ptp_interface_role{iface="eno8303",node="master-p4.perla4.lab.eng.cert.redhat.com",process="ptp4l"} 1
openshift_ptp_interface_role{iface="eno8403",node="master-p4.perla4.lab.eng.cert.redhat.com",process="ptp4l"} 5
```
Into switchover transition - both faulty (wrong):
```
openshift_ptp_interface_role{iface="eno8303",node="master-p4.perla4.lab.eng.cert.redhat.com",process="ptp4l"} 3
openshift_ptp_interface_role{iface="eno8403",node="master-p4.perla4.lab.eng.cert.redhat.com",process="ptp4l"} 3
```
Backup - OK
```
openshift_ptp_interface_role{iface="eno8303",node="master-p4.perla4.lab.eng.cert.redhat.com",process="ptp4l"} 3
openshift_ptp_interface_role{iface="eno8403",node="master-p4.perla4.lab.eng.cert.redhat.com",process="ptp4l"} 1
```
Back to normal - both SLAVE (not ok, eno8403 should be listening or master, depending on the real port state)
```
openshift_ptp_interface_role{iface="eno8303",node="master-p4.perla4.lab.eng.cert.redhat.com",process="ptp4l"} 1
openshift_ptp_interface_role{iface="eno8403",node="master-p4.perla4.lab.eng.cert.redhat.com",process="ptp4l"} 1
```
- Re-classify MASTER/LISTENING to UNCALIBRATED as LISTENING (not FAULTY)
- Add PRE_MASTER transition handling, mapped to MASTER
- Enforce single-SLAVE invariant per config for TBC profiles
Assisted by Claude
|
Skipping CI for Draft Pull Request. |
|
@vitus133: This pull request references Jira Issue OCPBUGS-111881, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nocturnalastro, vitus133 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified later @hhassid |
|
@vitus133: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@vitus133: This pull request references Jira Issue OCPBUGS-111881, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5049680
into
redhat-cne:main
|
@vitus133: Jira Issue OCPBUGS-111881: All pull requests linked via external trackers have merged: This pull request has the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fix T-BC dual-upstream port role metrics
Please note - this PR is fixing a part of the problem. To fully fix the problem, a companion PR in the
linuxptp-daemonis requiredProblem description: Dual-upstream T-BC port metrics are stale after switchover.
Solution:
Test
/cc @nocturnalastro @jzding @sebsoto @lack @edcdavid