ci: fix release skip chain, add sanity, remove update_pre_commit#251
Merged
Conversation
djdanielsson
force-pushed
the
ci/fix-release-skip-chain
branch
from
9dd22d8 to
95414ec
Compare
- Fix create_github_release skipped due to always() chain break - Replace ansible_collections_tooling pre-commit with pre-commit/action - Add Ansible sanity CI workflow - Pin all actions to commit SHAs - Remove update_pre_commit workflow (replaced by dependabot) Made-with: Cursor
djdanielsson
force-pushed
the
ci/fix-release-skip-chain
branch
from
95414ec to
2b671f1
Compare
Use ANSIBLE_GALAXY_SERVER_* env vars instead of generating temporary ansible.cfg files. Cleaner, no file cleanup needed, and avoids leaving secrets on disk. Made-with: Cursor
Create GitHub release as draft so tarball upload succeeds before publishing. Add !cancelled() guard to all downstream jobs. Update pre-commit-config to use prek-actions v26.4.1 with sanity hook. Made-with: Cursor
Add concurrency group so newer pushes cancel in-progress pre-commit workflow runs for the same PR or branch. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_github_releasejob (and all downstream) was being skipped becausechangelogusesalways()to handle themajor_release_gateskip chain, but downstream jobs didn't propagate this. Addedif: ${{ !cancelled() && needs.changelog.result == 'success' }}tocreate_github_release.ansible/ansible-content-actionsupdate_pre_commit.yml— dependabot already handles pre-commit version bumpsRoot cause
GitHub Actions gotcha: when a job uses
always()in itsifto run despite a skipped dependency, all downstream jobs that depend on it also need an explicitifcondition, otherwise they inherit the "skipped" status from the transitive dependency chain.Test plan
release_auto.ymlviaworkflow_dispatch— all jobs after changelog should now runMade with Cursor