Skip to content

Enable Configuration of Logging Format in Helm Chart Deployment - #137

Open
iflan7744 wants to merge 1 commit into
redhat-cop:masterfrom
NavVis-External:iflan7744-loggin-as-json
Open

Enable Configuration of Logging Format in Helm Chart Deployment#137
iflan7744 wants to merge 1 commit into
redhat-cop:masterfrom
NavVis-External:iflan7744-loggin-as-json

Conversation

@iflan7744

Copy link
Copy Markdown

This PR introduces an update to the Helm chart, enabling the selection of the logging format as either "development" or "production."

More info about log options,
https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/log/zap#Options.BindFlags

opts := zap.Options{Development: true,}
opts.BindFlags(flag.CommandLine)
flag.Parse()

By default, the helm chart deployment will use the development mode settings because the above code block, allowing logs to be in plain format.

However, with my changes to the helm chart, the user has the ability to tailor the log output to match their specific needs. Whether they prefer a JSON format for easier log parsing and analysis or a plain format for more straightforward readability, the helm chart now accommodates both options.

@iflan7744

Copy link
Copy Markdown
Author

@raffaelespazzoli can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant