This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Remove duplicate warning about Web Sockets - #278
Open
mbach04 wants to merge 2 commits into
Open
Conversation
lpsantil
suggested changes
May 31, 2018
lpsantil
left a comment
lpsantil
left a comment
Contributor
There was a problem hiding this comment.
Good catch but dupe also happens as line 113.
etsauer
previously approved these changes
Jul 20, 2018
Contributor
Contributor
|
@mbach04 any updates? |
Author
|
Sorry guys, I pulled a fly by PR on this one! I removed the additional duplicate and pushed to the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR About?
Duplicate warning in the docs about web sockets
How should we test or review this PR?
None, purely documentation.
Is there a relevant Trello card or Github issue open for this?
no
Who would you like to review this?
cc: @redhat-cop/cant-contain-this