Skip to content

chore(fullsend): allowlist claude.exe for Vertex STS - #3480

Merged
kadel merged 2 commits into
mainfrom
chore/fullsend-allow-claude-exe
Aug 31, 2026
Merged

chore(fullsend): allowlist claude.exe for Vertex STS#3480
kadel merged 2 commits into
mainfrom
chore/fullsend-allow-claude-exe

Conversation

@durandom

@durandom durandom commented Aug 31, 2026

Copy link
Copy Markdown
Member

Summary

  • Review on Skip or use lightweight retro analysis for bot-authored PRs fullsend-ai/fullsend#3317 failed because OpenShell denied /usr/lib/node_modules/@anthropic-ai/claude-code/bin/claude.exests.googleapis.com:443 (policy vertex_ai). **/claude does not match claude.exe.
  • Allowlist **/claude.exe on code, e2e-triage, and a forked review policy; point the review harness at the local policy.
  • Pin the review harness to ghcr.io/redhat-developer/rhdh-fullsend-code:latest (code/fix/e2e already use this image). Claude Code 2.1.243 in that image is what needs claude.exe.

Proven

Same image + claude.exe allowlist succeeded on rhdh-agentic fullsend-ai/fullsend#124 / fullsend-ai/fullsend#125:

Test plan

Evidence: https://github.com/redhat-developer/rhdh-plugin-export-overlays/actions/runs/33395911446/job/99500322474

Claude Code 2.1+ talks to sts.googleapis.com as claude.exe; **/claude does not match it, so review (and other agents) fail with policy_denied.

Co-authored-by: Cursor <cursoragent@cursor.com>
@durandom
durandom requested review from a team and subhashkhileri as code owners August 31, 2026 14:09
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure · Started 2:10 PM UTC · Completed 2:12 PM UTC

Commit: 993532d · View workflow run →

Runtime: claude · Model: opus → claude-opus-5

Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud

Copy link
Copy Markdown

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure · Started 2:51 PM UTC · Completed 2:53 PM UTC

Commit: 7139c94 · View workflow run →

Runtime: claude · Model: opus → claude-opus-5

@kadel

kadel commented Aug 31, 2026

Copy link
Copy Markdown
Member

fullsend only changs, no need to wait for CI

@kadel
kadel merged commit b4a4083 into main Aug 31, 2026
31 of 32 checks passed
@kadel
kadel deleted the chore/fullsend-allow-claude-exe branch August 31, 2026 15:05
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 3:06 PM UTC · Completed 3:19 PM UTC

Commit: 7139c94 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $6.88

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR fullsend-ai/fullsend#3480 — allowlist claude.exe for Vertex STS

What happened

PR fullsend-ai/fullsend#3480 was a human-authored infrastructure fix (co-authored with Cursor) that addressed a sandbox policy gap: Claude Code 2.1.243+ ships its binary as claude.exe (bun compile) instead of claude, so the existing **/claude glob in sandbox network policies did not match it. This caused policy_denied errors when the binary tried to reach sts.googleapis.com:443 for Vertex AI STS token exchange.

The PR added **/claude.exe to the code.yaml and e2e-triage.yaml policies, created a new local review.yaml policy fork with the same fix, and pinned the review harness to ghcr.io/redhat-developer/rhdh-fullsend-code:latest.

Both review agent runs failed (run 1, run 2) — expected, since the review agent checked out the base branch config (which didn't yet include the fix). This is a chicken-and-egg situation: the PR fixing the review agent's sandbox policy cannot itself be reviewed by the review agent.

A human reviewer (kadel) approved and merged within ~1 hour, correctly noting these were fullsend-only changes that didn't need CI.

Key finding: upstream fix is missing

The fix only lives in this repo's local .fullsend/ policy forks. The upstream agents repo (fullsend-ai/agents) still does not have **/claude.exe in its Vertex AI profile (profiles/fullsend-vertex-ai.yaml). Any repo relying on the default fleet profile (without a local policy override) is susceptible to the same policy_denied failure when running Claude Code 2.1.243+.

Existing issue coverage

Proposals skipped (target repo not allowed)

File manually or update create_issues.allow_targets in config.yaml:

  • Add **/claude.exe to Vertex AI profile binary allowlist (fullsend-ai/agents)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants