Skip to content

Enable zombie_cluster_resource in dry_run=no for ecoeng_01 - #1031

Merged
pragya811 merged 1 commit into
mainfrom
enable/ecoeng01-zombie-cluster-dry-run-no
Aug 26, 2026
Merged

Enable zombie_cluster_resource in dry_run=no for ecoeng_01#1031
pragya811 merged 1 commit into
mainfrom
enable/ecoeng01-zombie-cluster-dry-run-no

Conversation

@pragya811

Copy link
Copy Markdown
Member

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Add zombie_cluster_resource to POLICIES_IN_ACTION so it runs in dry_run=no mode for the ecoeng_01 tenant accounts, matching the existing cleanup policies already in action.

For security reasons, all pull requests need to be approved first before running any automated CI

Add zombie_cluster_resource to POLICIES_IN_ACTION so it runs in
dry_run=no mode for the ecoeng_01 tenant accounts, matching the
existing cleanup policies already in action.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 5df18a4b-1759-4188-b1b9-9e800148594e

📥 Commits

Reviewing files that changed from the base of the PR and between 526bb3e and 8ce6cb5.

📒 Files selected for processing (1)
  • jenkins/tenant/aws/ecoeng_01/PolicyJenkinsfileDaily

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Enabled the zombie cluster resource policy to run in active, non-dry-run mode.

Walkthrough

The daily Jenkins policy configuration adds zombie_cluster_resource to POLICIES_IN_ACTION, enabling non-dry-run execution.

Changes

Policy execution

Layer / File(s) Summary
Enable zombie cluster policy
jenkins/tenant/aws/ecoeng_01/PolicyJenkinsfileDaily
POLICIES_IN_ACTION now includes zombie_cluster_resource.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 8ce6c

This localized change enables the existing zombie-cluster cleanup policy for ecoeng_01 accounts in non-dry-run mode; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that zombie_cluster_resource will run with dry_run=no for ecoeng_01, which is the main change.
Description check ✅ Passed The description directly explains the policy change and its effect on the ecoeng_01 tenant accounts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)


Comment @coderabbitai help to get the list of available commands.

@pragya811 pragya811 self-assigned this Aug 25, 2026
@pragya811 pragya811 added the dependencies Pull requests that update a dependency file label Aug 25, 2026

@ebattat ebattat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@pragya811
pragya811 merged commit 52bdc5e into main Aug 26, 2026
19 checks passed
@pragya811
pragya811 deleted the enable/ecoeng01-zombie-cluster-dry-run-no branch August 26, 2026 11:33
@github-project-automation github-project-automation Bot moved this from In progress to Done in Cloud-Governance project Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Development

Successfully merging this pull request may close these issues.

2 participants