ci: add ESLint as blocking CI step #5347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelangelow
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pd-redis and
valkirilov
as code owners
Contributor
Code Coverage - Integration Tests
|
Contributor
Code Coverage - Frontend unit tests
Test suite run success5487 tests passing in 704 suites. Report generated by 🧪jest coverage report action from 030f55b |
Contributor
Code Coverage - Backend unit tests
Test suite run success3012 tests passing in 287 suites. Report generated by 🧪jest coverage report action from 030f55b |
valkirilov
previously approved these changes
Dec 19, 2025
pawelangelow
dismissed
valkirilov’s stale review
The base branch was changed.
- Add lint.yml reusable workflow that runs yarn lint - Update tests.yml to call lint workflow first - All test jobs now depend on lint passing
Add inline eslint-disable comments for imports from api/dist which doesn't exist in CI (clean checkout without build artifacts).
Lint is now run as a blocking step before tests start, making this Slack-reporting-only step redundant.
pawelangelow
force-pushed
the
feature/run-eslint-in-ci
branch
from
e92effd to
030f55b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds ESLint as a blocking step in CI before tests run:
lint.ymlworkflow - Runs ESLint as a required check that blocks test execution if linting failsapi/distfolderChanges
Testing
CI pipeline runs on the branch.
Success pipeline
Exit as soon as the linting fails
Pull Request opened by Augment Code with guidance from the PR author
Note
Introduces a blocking ESLint workflow and makes all test jobs depend on it, while removing legacy non-blocking lint steps; adds ESLint import-extension ignores for desktop server imports.
/.github/workflows/lint.ymlto runyarn lint.tests.ymlto add alintjob and setfrontend-tests,backend-tests, andintegration-teststoneeds: [changes, lint].tests-frontend.ymlandtests-backend.ymlthat only posted Slack reports.eslint-disable import/extensionscomments forapi/distimports inredisinsight/desktop/src/lib/server/server.ts.Written by Cursor Bugbot for commit 030f55b. This will update automatically on new commits. Configure here.