Conversation
There was a problem hiding this comment.
The decoupling of tag validation from the client package is well-executed. The implementation correctly duplicates the validation logic and adds appropriate test coverage.
🤖 Automated review complete. Please react with 👍 or 👎 on the individual review comments to provide feedback on their usefulness.
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent_memory_client.utils0.14.1, the server to0.15.1, and requireagent-memory-client>=0.14.1ruff checkpassesVerification
uv run pytest --run-api-testscd agent-memory-client && uv run pytestuv run ruff checkagent_memory_client-0.14.1wheel and verifiedagent_memory_client.utils.tag_codecimports from a clean venvagent_memory_server-0.15.1+agent_memory_client-0.14.1wheels and verifiedagent_memory_server.cliandagent_memory_server.modelsimport from a clean venvagent_memory_server-0.15.1no longer resolves withagent-memory-client==0.14.0because of the new dependency floorNote
Medium Risk
Moderate risk because it changes a Pydantic validation dependency path and enforces a new minimum
agent-memory-clientversion, which can affect packaging/import behavior and deployments with pinned dependencies.Overview
Fixes a packaging/import mismatch in tag validation by inlining
validate_no_commas_in_tagsinagent_memory_server.utils.tag_codecinstead of importing it from the Python client, and adds a regression test to ensure the server module imports even whenagent_memory_client.utilsis missing.Versioning/deps are updated: client bumps to
0.14.1, server to0.15.1, andpyproject.tomlnow requiresagent-memory-client>=0.14.1(including dev extras). The interactive guide notebook is also adjusted (e.g.,datetime.UTCusage / minor formatting) to keep repo-wideruffchecks passing.Written by Cursor Bugbot for commit 7ac14c5. This will update automatically on new commits. Configure here.