RS: Cert based auth for CRDB - #3756
Conversation
🧠 Redis MemoryFound 5 related items from repository history:
Memory updated at 5baf3bc |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5baf3bc. Configure here.
| | replace_node | integer | Replaces the specified node with the new node (optional) | | ||
| | second_rack_id | string | The unique identifier of the node's second rack ID for two-dimensional rack awareness (optional) | | ||
| | username | email address | Admin user's email address | | ||
| | trusted_ca | filepath | Path to a file containing the CA that validates the API certificate the cluster presents, in PEM format. If you omit it, the node uses the certificates in the cluster's `mtls_trusted_ca.pem` file. (optional) | |
There was a problem hiding this comment.
Join trusted_ca default wording
Medium Severity
For optional trusted_ca on rladmin cluster join, the new text says the joining node falls back to the cluster's mtls_trusted_ca.pem. Before a successful join, that node is not yet a member of the target cluster, so implying the target cluster’s on-disk trust store is used is inconsistent with how join authentication works.
Reviewed by Cursor Bugbot for commit 5baf3bc. Configure here.


Note
Low Risk
Documentation-only updates to CLI, REST reference, and security guides; no application code changes in this PR.
Overview
Documents certificate-based cluster management for Redis Software when basic/digest REST auth is off or unavailable—especially Active-Active (CRDB) and node join—without changing product behavior in this diff.
crdb-clireference pages forcreate,add-instance, andupdatenow describe--instance/--credentialsas accepting either username/password orclient_cert/client_key/ optionaltrusted_ca(PEM), including the mutual-exclusion error and examples for mixed clusters and migrating an instance to certs.rladmin cluster joindocuments the same auth choice using file paths for cert/key/CA;rladmin tune clusteraddscontrol_plane_basic_authentication.REST object docs add cert fields on bootstrap
credentialsand acertificate_authblock on CRDBcluster_info(vscredentials).Security guides gain a cluster management section in certificate-based authentication (bootstrap join, AA create/add-instance/update, REST
certificate_auth) and a step-by-step order in disable-basic-authentication before turning off basic auth.Reviewed by Cursor Bugbot for commit 5baf3bc. Bugbot is set up for automated code reviews on this repo. Configure here.