Repository navigation
http/routes: replace deprecated done() with set_content_type() - #279
Merged
travisdowns merged 1 commit intoMay 22, 2026
Merged
Conversation
WillemKauf
approved these changes
May 19, 2026
Member
|
Is this just a local fix? |
Member
Author
It happens to land in code we are carrying only on our fork, yes. There is an an open PR to upstream that older code, but not yet merged. So it can be dropped in 26.3.x if PR merges or fixed-up into our fork commit otherwise. edit: the OG change just landed upstream: scylladb@3be4d96 so this would drop out next rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated
reply::done(content_type)call with the equivalentset_content_type()call it forwarded to, fixing the compiler deprecation warning.