Skip to content

[v26.2.x] dns: fix build with c-ares 1.34.7 constified host callback #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartoszpiekny-redpanda merged 1 commit into from
Aug 7, 2026
Merged

[v26.2.x] dns: fix build with c-ares 1.34.7 constified host callback #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/net/dns.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include <arpa/nameser.h>
#include <chrono>
#include <memory>
#include <concepts>

#include <ares.h>
#include <boost/lexical_cast.hpp>
Expand Down Expand Up @@ -595,7 +596,10 @@ dns_resolver::impl::get_host_by_addr(inet_address addr) {

dns_call call(*this);

ares_gethostbyaddr(_channel, p->addr.data(), p->addr.size(), int(p->addr.in_family()), [](void* arg, int status, int timeouts, ::hostent* host) {
// c-ares 1.34.7 constified the hostent argument to ares_host_callback (upstream
// PR #1060), but 1.34.8 reverted it. Rather than key on the version, use a template
// that matches both variants.
ares_gethostbyaddr(_channel, p->addr.data(), p->addr.size(), int(p->addr.in_family()), [](void* arg, int status, int timeouts, std::convertible_to<const ::hostent*> auto host) {
// we do potentially allocating operations below, so wrap the pointer in a
// unique here.
std::unique_ptr<promise_wrap> p(reinterpret_cast<promise_wrap *>(arg));
Expand Down
Loading