core/reactor: add SIGFPE handler - #311
Merged
Merged
Conversation
SIGFPE is a notable & potentially common enough error that it deserves a handler in seastar - divisions by zero (including % 0 operations), integer overflows, etc., are commonplace bugs for developers to run into. Add one alongside the existing signal handlers to ensure we print a backtrace for aiding developers in debugging before crashing. (cherry picked from commit 30a07cf)
travisdowns
approved these changes
Aug 31, 2026
WillemKauf
enabled auto-merge (rebase)
August 31, 2026 14:00
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
Adds a dedicated SIGFPE (floating-point exception) signal handler to Seastar’s reactor startup path so that common arithmetic faults (e.g., division/modulo by zero, some overflow traps) produce a backtrace before the process terminates—consistent with existing fatal-signal diagnostics.
Changes:
- Introduce a
sigfpe_action()handler that prints a backtrace and re-raisesSIGFPE. - Register the SIGFPE handler during
smp::configure()alongside existing SIGSEGV/SIGABRT/SIGILL handlers.
File summaries
| File | Description |
|---|---|
src/core/reactor.cc |
Adds SIGFPE handler implementation and installs it during reactor/SMP configuration. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGFPE is a notable & potentially common enough error that it deserves a handler in seastar - divisions by zero (including % 0 operations), integer overflows, etc., are commonplace bugs for developers to run into.
Add one alongside the existing signal handlers to ensure we print a backtrace for aiding developers in debugging before crashing.
(cherry picked from commit 30a07cf)