Fix pymodbus ≥3.0 compatibility by replacing unpack_bitstring import#24
Open
Uhae wants to merge 1 commit into
Open
Fix pymodbus ≥3.0 compatibility by replacing unpack_bitstring import#24Uhae wants to merge 1 commit into
Uhae wants to merge 1 commit into
Conversation
|
thank you, it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integration fails on pymodbus 3.x due to:
ImportError: cannot import name 'unpack_bitstring' from 'pymodbus.utilities'
This PR removes the broken import and replaces it with a local implementation of
unpack_bitstring()(copied from pymodbus 2.x). Also corrects an indentation bug that caused__init__()to break.Tested with:
pymodbus==3.3.0Restores full compatibility with newer HA installs.