chore: node 24 by rpiszczatowski · Pull Request #9 · redstone-finance/suiangria

rpiszczatowski · 2026-04-07T15:03:16Z

No description provided.

kilo-code-bot · 2026-04-07T15:07:26Z

Code Review Summary

Status: 14 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	9
WARNING	5
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`.github/workflows/build-artifacts.yml`	N/A	`cargo` is not installed in the Docker images, and the installation path will be broken.
`.github/workflows/build-artifacts.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/ts-ci.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	N/A	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	N/A	Missing `-f` flag in `curl` command.
`.github/workflows/ts-ci.yml`	N/A	Missing `-f` flag in `curl` command.

WARNING

File	Line	Issue
`.github/workflows/build-artifacts.yml`	63	Incomplete Node version bump.
`.github/workflows/build-artifacts.yml`	N/A	Security best practice violation: inline secret interpolation.
`.github/workflows/build-artifacts.yml`	N/A	Security best practice violation: inline secret interpolation.
`.github/workflows/build-artifacts.yml`	N/A	Security best practice violation: inline secret interpolation.
`.github/workflows/ts-ci.yml`	N/A	Security best practice violation: inline secret interpolation.

Files Reviewed (8 files)

.github/workflows/build-artifacts.yml - 11 issues
.github/workflows/ts-ci.yml - 3 issues
.github/workflows/rust-ci.yml
.gitignore
Cargo.lock
package.json
tsconfig.json
yarn.lock

Fix these issues in Kilo Cloud

Previous Review Summaries (8 snapshots, latest commit fccd275)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit `fccd275`)

Status: 14 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	9
WARNING	5
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`.github/workflows/build-artifacts.yml`	N/A	`cargo` is not installed in the Docker images, and the installation path will be broken.
`.github/workflows/build-artifacts.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/ts-ci.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	N/A	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	N/A	Missing `-f` flag in `curl` command.
`.github/workflows/ts-ci.yml`	N/A	Missing `-f` flag in `curl` command.

WARNING

File	Line	Issue
`.github/workflows/build-artifacts.yml`	63	Incomplete Node version bump.
`.github/workflows/build-artifacts.yml`	N/A	Security best practice violation: inline secret interpolation.
`.github/workflows/build-artifacts.yml`	N/A	Security best practice violation: inline secret interpolation.
`.github/workflows/build-artifacts.yml`	N/A	Security best practice violation: inline secret interpolation.
`.github/workflows/ts-ci.yml`	N/A	Security best practice violation: inline secret interpolation.

Files Reviewed (6 files)

.github/workflows/build-artifacts.yml - 11 issues
.github/workflows/ts-ci.yml - 3 issues
.github/workflows/rust-ci.yml
package.json
tsconfig.json
yarn.lock

Fix these issues in Kilo Cloud

Previous review (commit `caa3b37`)

Status: 13 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	9
WARNING	4
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`.github/workflows/build-artifacts.yml`	203	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	266	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	289	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	`cargo` is not installed in the Docker images, and the installation path will be broken.
`.github/workflows/ts-ci.yml`	55	Missing `-f` flag in `curl` command.
`.github/workflows/ts-ci.yml`	N/A	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.

WARNING

File	Line	Issue
`.github/workflows/build-artifacts.yml`	202	Security best practice violation: inline secret interpolation.
`.github/workflows/build-artifacts.yml`	265	Security best practice violation: inline secret interpolation.
`.github/workflows/build-artifacts.yml`	288	Security best practice violation: inline secret interpolation.
`.github/workflows/ts-ci.yml`	54	Security best practice violation: inline secret interpolation.

Files Reviewed (6 files)

.github/workflows/build-artifacts.yml - 10 issues
.github/workflows/ts-ci.yml - 3 issues
.github/workflows/rust-ci.yml
package.json
tsconfig.json
yarn.lock

Fix these issues in Kilo Cloud

Previous review (commit `74961f0`)

Status: 10 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	9
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`.github/workflows/build-artifacts.yml`	202	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	202	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	264	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	264	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	286	Missing `-f` flag in `curl` command.
`.github/workflows/build-artifacts.yml`	286	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	`cargo` is not installed in the Docker images, and the installation path will be broken.
`.github/workflows/ts-ci.yml`	54	Missing `-f` flag in `curl` command.
`.github/workflows/ts-ci.yml`	54	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.

WARNING

File	Line	Issue
`.github/workflows/build-artifacts.yml`	62	Incomplete Node version bump.

Files Reviewed (6 files)

.github/workflows/build-artifacts.yml - 8 issues
.github/workflows/ts-ci.yml - 2 issues
.github/workflows/rust-ci.yml
package.json
tsconfig.json
yarn.lock

Fix these issues in Kilo Cloud

Previous review (commit `8ece557`)

Status: 5 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	5
WARNING	0
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`.github/workflows/build-artifacts.yml`	202	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	264	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	286	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.
`.github/workflows/build-artifacts.yml`	N/A	`cargo` is not installed in the Docker images, and the installation path will be broken.
`.github/workflows/ts-ci.yml`	54	Passing `GITHUB_TOKEN` to fetch a script from a different organization will cause the request to fail with an HTTP error.

Files Reviewed (6 files)

.github/workflows/build-artifacts.yml - 4 issues
.github/workflows/ts-ci.yml - 1 issue
.github/workflows/rust-ci.yml
package.json
tsconfig.json
yarn.lock

Fix these issues in Kilo Cloud

Previous review (commit `fb1c85b`)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	1
WARNING	0
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`.github/workflows/build-artifacts.yml`	286	`cargo` is not installed in the Docker images, and the installation path will be broken.

Files Reviewed (6 files)

.github/workflows/build-artifacts.yml - 1 issue
.github/workflows/rust-ci.yml
.github/workflows/ts-ci.yml
package.json
tsconfig.json
yarn.lock

Fix these issues in Kilo Cloud

Previous review (commit `6c8b218`)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)

.github/workflows/build-artifacts.yml
.github/workflows/rust-ci.yml
.github/workflows/ts-ci.yml
package.json
tsconfig.json
yarn.lock

Previous review (commit `5547d0d`)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
WARNING	1

Issue Details (click to expand)

WARNING

File	Line	Issue
`.github/workflows/build-artifacts.yml`	62	Node version matrices are out of sync with the main build environment bump to Node 24

Files Reviewed (6 files)

.github/workflows/build-artifacts.yml - 1 issue
.github/workflows/rust-ci.yml
.github/workflows/ts-ci.yml
package.json
tsconfig.json
yarn.lock

Previous review (commit `13668d1`)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)

.github/workflows/build-artifacts.yml
.github/workflows/rust-ci.yml
.github/workflows/ts-ci.yml
package.json

_{Reviewed by gemini-3.1-pro-preview · Input: 70.9K · Output: 4.7K · Cached: 273.9K}

chore: node 24

13668d1

rpiszczatowski marked this pull request as ready for review April 7, 2026 15:06

rpiszczatowski marked this pull request as draft May 6, 2026 05:18

rpiszczatowski added 2 commits June 21, 2026 22:52

fix

594498b

fix

5547d0d

rpiszczatowski marked this pull request as ready for review June 21, 2026 21:43

rpiszczatowski enabled auto-merge (squash) June 21, 2026 21:44

kilo-code-bot Bot reviewed Jun 21, 2026

View reviewed changes

Comment thread .github/workflows/build-artifacts.yml

fix

6c8b218

rpiszczatowski requested a review from kostekIV June 22, 2026 06:07

use cargo

fb1c85b

kilo-code-bot Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread .github/workflows/build-artifacts.yml Outdated

auth

8ece557

kilo-code-bot Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread .github/workflows/build-artifacts.yml Outdated

Comment thread .github/workflows/build-artifacts.yml Outdated

Comment thread .github/workflows/build-artifacts.yml Outdated

Comment thread .github/workflows/ts-ci.yml Outdated

logs

74961f0

kilo-code-bot Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread .github/workflows/build-artifacts.yml Outdated

Comment thread .github/workflows/build-artifacts.yml Outdated

Comment thread .github/workflows/build-artifacts.yml Outdated

Comment thread .github/workflows/ts-ci.yml Outdated

auth

caa3b37

kilo-code-bot Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread .github/workflows/build-artifacts.yml Outdated

Comment thread .github/workflows/build-artifacts.yml Outdated

Comment thread .github/workflows/build-artifacts.yml Outdated

Comment thread .github/workflows/ts-ci.yml Outdated

rpiszczatowski and others added 2 commits June 22, 2026 12:17

fix

fccd275

cargo.lock

6532a38

szynwelski approved these changes Jun 22, 2026

View reviewed changes

rpiszczatowski merged commit 4e69911 into main Jun 22, 2026
1 check passed

rpiszczatowski deleted the robal/node-24 branch June 22, 2026 11:09

Conversation

rpiszczatowski commented Apr 7, 2026

Uh oh!

kilo-code-bot Bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Overview

CRITICAL

WARNING

Previous review (commit fccd275)

Overview

CRITICAL

WARNING

Previous review (commit caa3b37)

Overview

CRITICAL

WARNING

Previous review (commit 74961f0)

Overview

CRITICAL

WARNING

Previous review (commit 8ece557)

Overview

CRITICAL

Previous review (commit fb1c85b)

Overview

CRITICAL

Previous review (commit 6c8b218)

Previous review (commit 5547d0d)

Overview

WARNING

Previous review (commit 13668d1)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kilo-code-bot Bot commented Apr 7, 2026 •

edited

Loading

Previous review (commit `fccd275`)

Previous review (commit `caa3b37`)

Previous review (commit `74961f0`)

Previous review (commit `8ece557`)

Previous review (commit `fb1c85b`)

Previous review (commit `6c8b218`)

Previous review (commit `5547d0d`)

Previous review (commit `13668d1`)