Merged
Conversation
redstrate
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for diving and surfacing. I added it in the least intrusive way possible since I'm not overly familiar with the zoning code. That said, you can dive and surface with the correct visual loading effects. Entering underwater portals into Tamamizu etc is not yet supported due to the strange way it's done.
The underwater portals seem to provide some sort of key or index that leads to a poprange (glanced at Sapphire out of curiosity) but trying it both as an exit box and poprange failed, so I'm not sure how you're supposed to find where to put the player. I left comments with observed values so we don't forget.