Merged
Conversation
Owner
This is the method I was thinking of, I was under the assumption you could maybe use |
redstrate
reviewed
Mar 14, 2026
redstrate
reviewed
Mar 14, 2026
Co-authored-by: Joshua Goins <josh@redstrate.com>
redstrate
approved these changes
Mar 14, 2026
Owner
redstrate
left a comment
There was a problem hiding this comment.
Thanks! LGTM is very much appreciated (along with the tests as well)
Contributor
Author
You get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional glam feature flag for less friction on type coercion. Because of Rust's orphan rules, this is the type of thing that can only live in this library, outside of an intermediate type being implemented. This came about because I was thinking about what was discussed in this issue: redstrate/Kawari#323
There a few options:
Affine3aand implementsFrom<Transformation>fn physis_transform_to_affine3a(transformation: &Transformation) -> Affine3A