-
Notifications
You must be signed in to change notification settings - Fork 0
feat(player): 코드 컬러 보이싱 + 베이스 토닉 (화음 발성 2단계) #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 38 additions & 0 deletions
38
docs/superpowers/specs/2026-08-04-player-chord-voicing-design.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Maestro Player 화음 발성 2단계 설계 (코드 컬러 보이싱 + 베이스) | ||
|
|
||
| - 날짜: 2026-08-04 | ||
| - 상태: 확정 (음높이 배선 1단계의 예고된 후속) | ||
| - 범위: `player/` 하위만 | ||
|
|
||
| ## 0. 목표 | ||
|
|
||
| 1단계에서 멜로디 음높이가 조성·선법에 배선됐다. 2단계는 지금까지 라벨로만 | ||
| 존재하던 `harmony.chordColor`(triad/add9/sus2/sus4/maj7/flat7)를 실제 | ||
| 동시 발성으로 만들고 베이스 토닉을 깔아 "화성이 울리는" 소리를 만든다. | ||
|
|
||
| ## 1. 규칙 | ||
|
|
||
| - `musicTheory.buildChordOffsets(chordColor, mode)`: 컬러별 기본 구성음 | ||
| (triad [0,4,7], add9 +14, sus2 [0,2,7], sus4 [0,5,7], maj7 +11, flat7 +10)을 | ||
| **선법 스케일에 스냅** — 단3도 선법(dorian/phrygian/aeolian)에서는 3도가 | ||
| 자동으로 단3도(3)로 조정된다. 결과적으로 스케일 적합률 게이트가 유지된다. | ||
| - `chartMapper`: **accent·hold 노트에만** `chordMidis` 부여 — | ||
| `[베이스 토닉(36+tonicIndex), ...(48+tonicIndex+chordOffsets)]`. | ||
| tap 노트는 단선율 유지(과밀 방지). | ||
| - `replayAudioEngine`: cue에 `chordFrequencies` 전달, 재생 시 메인 음 외에 | ||
| 화음 음마다 sine 오실레이터 추가(게인 ×0.35, 길이 ×1.6 — 패드 느낌). | ||
| hold는 기존 -1옥타브 메인 위에 화음이 얹혀 패드+베이스 역할. | ||
| - `scaleConformance`는 chordFrequencies까지 검사하도록 확장(게이트 강화). | ||
|
|
||
| ## 2. 테스트 | ||
|
|
||
| - buildChordOffsets: dorian triad→[0,3,7], dorian maj7의 11→10 스냅. | ||
| - chartMapper: accent 노트에 chordMidis(베이스 최저음 포함) 존재, tap에는 없음, | ||
| 전부 스케일 적합. | ||
| - replayAudioEngine: chordFrequencies가 있는 cue 재생 시 오실레이터 수 = | ||
| 1+화음 수, 주파수 목록에 화음 주파수 포함. | ||
| - 기존 하니스(스케일·그리드·밀도·도약) + fingerprint 결정성 무회귀. | ||
|
|
||
| ## 3. 비범위 | ||
|
|
||
| 보이스리딩(전위 선택), 벨로시티 커브, 악기 음색(신스 패치)은 후속. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When accent cues contain several conforming chord voices, incrementing
totalfor every frequency dilutes an invalid lead note and weakens the existing ≥95% gate inmusicTheoryHarness.test.mjs. For example, ten accent cues with four chord tones each and one off-scale lead report 49/50 = 98% instead of the cue-level 9/10 = 90%, allowing a regression affecting 10% of cues to pass; mark a cue nonconformant when any of its sounding frequencies is outside the scale, or gate cue and voice ratios separately.Useful? React with 👍 / 👎.