Skip to content

feat(player): A/B 대조 청취 픽스처 + 블라인드 프로토콜 - #53

Merged
redsunjin merged 2 commits into
mainfrom
feat/player-ab-contrast
Aug 5, 2026
Merged

feat(player): A/B 대조 청취 픽스처 + 블라인드 프로토콜#53
redsunjin merged 2 commits into
mainfrom
feat/player-ab-contrast

Conversation

@redsunjin

Copy link
Copy Markdown
Owner

요약

"좋은 코딩이 듣기 좋게 들리는가" 가설의 직접 검증 장치.
스펙: docs/superpowers/specs/2026-08-04-player-ab-contrast-design.md

  • 통제된 대조 쌍: 같은 저장소·같은 PR 번호 → 조성(tonic)·모티프 동일. 차이는 이벤트 내용뿐 — A(적정 커밋→리뷰 반영→approve→merge) vs B(대형 덤프+revert×3+reopen, 머지 없음).
  • 자동 대조 게이트(tests/contrastListening.test.mjs): tonic 동일 확인, A=ionian vs B=phrygian, B=sus4 긴장 코드, B 평균 긴장 ≥ A+0.15, A 해소 ≥ B+0.1, A 해소 정점=merge·B는 부재 — 첫 실행에 전부 통과(매핑 규칙이 실제로 이 방향으로 번역함을 확인).
  • 골든 팩 3→5 엔트리: 두 데모가 카드로 노출되어 나란히 청취 가능. 기존 정량 하니스(스케일·그리드·밀도·도약)에 자동 편입.
  • 블라인드 청취 프로토콜(docs/maestro-player/ab-listening-protocol.md): 라벨 숨김·무작위 순서·3문항·과반 판정, 결과는 evidence로 축적.
  • 하니스 조정: 종지 없는 픽스처는 accent 0이 음악적으로 정상 — 단언을 "존재 시 검증+전체 1개 이상"으로.

검증

npm run qa 전체(node 93 + UI 33 + 하니스 8) 통과, 프리뷰에서 5개 카드 렌더 확인, build:extension 통과.

경계

player/ + docs/maestro-player/ + 스펙 문서만 수정.

🤖 Generated with Claude Code

selimDGAX and others added 2 commits August 5, 2026 09:10
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
같은 repo+PR(=같은 조성·모티프 통제)에서 모범 PR 흐름(A)과 거친
이력(B: 대형 덤프+revert x3+reopen, 머지 없음)을 골든 팩에 추가.
자동 대조 게이트: A=ionian vs B=phrygian, B=sus4, 긴장/해소 마진,
A의 해소 정점=merge·B는 merge 부재. 블라인드 청취 프로토콜 문서 추가.
종지 없는 픽스처는 accent 0이 정상이므로 하니스 단언을 조정.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 593f72acad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +98 to +99
// 종지 없는 픽스처(예: 거친 이력 대조 B)는 accent가 0일 수 있다 — 있는 경우만 검증
accentTotal += accents.length;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep accent coverage scoped to cadenced fixtures

With the new rough B fixture this relaxation is needed only for sessions that intentionally have no cadence/merge, but applying it to every fixture means an existing golden scenario can lose all accent notes and the harness still passes as long as some other fixture has one. That would stop this test from catching broken merge/cadence chord voicing on individual scenarios; please keep the per-fixture assertion for fixtures that contain cadence-producing events and exempt only the unresolved contrast case.

Useful? React with 👍 / 👎.

@redsunjin
redsunjin merged commit 82bdd22 into main Aug 5, 2026
4 checks passed
@redsunjin
redsunjin deleted the feat/player-ab-contrast branch August 5, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants