feat(player): A/B 대조 청취 픽스처 + 블라인드 프로토콜 - #53
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
같은 repo+PR(=같은 조성·모티프 통제)에서 모범 PR 흐름(A)과 거친 이력(B: 대형 덤프+revert x3+reopen, 머지 없음)을 골든 팩에 추가. 자동 대조 게이트: A=ionian vs B=phrygian, B=sus4, 긴장/해소 마진, A의 해소 정점=merge·B는 merge 부재. 블라인드 청취 프로토콜 문서 추가. 종지 없는 픽스처는 accent 0이 정상이므로 하니스 단언을 조정. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 593f72acad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // 종지 없는 픽스처(예: 거친 이력 대조 B)는 accent가 0일 수 있다 — 있는 경우만 검증 | ||
| accentTotal += accents.length; |
There was a problem hiding this comment.
Keep accent coverage scoped to cadenced fixtures
With the new rough B fixture this relaxation is needed only for sessions that intentionally have no cadence/merge, but applying it to every fixture means an existing golden scenario can lose all accent notes and the harness still passes as long as some other fixture has one. That would stop this test from catching broken merge/cadence chord voicing on individual scenarios; please keep the per-fixture assertion for fixtures that contain cadence-producing events and exempt only the unresolved contrast case.
Useful? React with 👍 / 👎.
요약
"좋은 코딩이 듣기 좋게 들리는가" 가설의 직접 검증 장치.
스펙:
docs/superpowers/specs/2026-08-04-player-ab-contrast-design.mdtests/contrastListening.test.mjs): tonic 동일 확인, A=ionian vs B=phrygian, B=sus4 긴장 코드, B 평균 긴장 ≥ A+0.15, A 해소 ≥ B+0.1, A 해소 정점=merge·B는 부재 — 첫 실행에 전부 통과(매핑 규칙이 실제로 이 방향으로 번역함을 확인).docs/maestro-player/ab-listening-protocol.md): 라벨 숨김·무작위 순서·3문항·과반 판정, 결과는 evidence로 축적.검증
npm run qa전체(node 93 + UI 33 + 하니스 8) 통과, 프리뷰에서 5개 카드 렌더 확인,build:extension통과.경계
player/+docs/maestro-player/+ 스펙 문서만 수정.🤖 Generated with Claude Code