Merged
Conversation
Fix WalletClient to load saved LSP from keychain on startup. Resolves issue where LSP selection reverted to default after restart. The fix is in WalletClient.start() which now properly loads the persisted LSP selection from KeyService on app startup.
reez
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Fixes dependency injection by using self.keyClient.getLSP() instead of KeyClient.live.getLSP(), ensuring mock mode works correctly and maintaining proper separation of concerns.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Use self.keyClient.getBackupInfo() instead of KeyClient.live.getBackupInfo() to maintain consistency with LSP loading and ensure both backup info and LSP data come from the same source (live or mock) in all app modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix WalletClient to load saved LSP from keychain on startup. Resolves issue where LSP selection reverted to default after restart.
The fix is in WalletClient.start() which now loads the persisted LSP selection from KeyService on app startup.
Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
.swift-formatfileNew Features:
Bugfixes: