Skip to content

ci: 26 for ios xcode, iphone 17 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reez merged 1 commit into from
Oct 2, 2025
Merged

ci: 26 for ios xcode, iphone 17 #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ on:
jobs:
build:
name: Build and Test default scheme using any available iPhone simulator
runs-on: macos-14
runs-on: macos-26

steps:
- name: Checkout
uses: actions/checkout@v3
- name: Select Xcode Version
run: sudo xcode-select -switch /Applications/Xcode_15.4.app
run: sudo xcode-select -switch /Applications/Xcode_26.0.app
# - name: Set Default Scheme
# run: |
# scheme_list=$(xcodebuild -list -json | tr -d "\n")
Expand All @@ -25,4 +25,4 @@ jobs:
# - name: List Devices
# run: xcrun xctrace list devices 2>&1
# - name: Build
# run: xcodebuild build-for-testing -scheme LDKNodeMonday -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 15,OS=17.2'
# run: xcodebuild build-for-testing -scheme LDKNodeMonday -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 17,OS=26.0'
Copy link
Copy Markdown

@cursor cursor bot Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: CI Workflow Uses Future Versions

The CI workflow configuration uses non-existent version numbers for the GitHub Actions runner (macos-26), Xcode installation (Xcode_26.0.app), and the iOS simulator target (iPhone 17,OS=26.0). These versions are far beyond current releases and will cause the workflow to fail.

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Owner Author

@reez reez Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont know what you're talking about